Add namespace::autoclean, move make_immutable calls down to the bottom of the package

bobtfish · bobtfish · commit dd6d4b4643ec · 2010-01-11T19:59:47.000Z
diff --git a/Makefile.PL b/Makefile.PL
@@ -23,6 +23,7 @@ requires        'IO::Digest'                 => '0';
 requires        'Moose'                      => '0';
 requires        'MooseX::StrictConstructor'  => '0';
 requires        'MooseX::Types::Path::Class' => '0';
+requires 'namespace::autoclean';
 
 test_requires   'Test::More'                 => '0.88';
 
diff --git a/lib/Git/PurePerl.pm b/lib/Git/PurePerl.pm
@@ -35,6 +35,8 @@ use Git::PurePerl::Protocol;
 use IO::Digest;
 use IO::Socket::INET;
 use Path::Class;
+use namespace::autoclean;
+
 our $VERSION = '0.45';
 $VERSION = eval $VERSION;
 
diff --git a/lib/Git/PurePerl/Actor.pm b/lib/Git/PurePerl/Actor.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::Actor;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 has 'name'  => ( is => 'ro', isa => 'Str', required => 1 );
 has 'email' => ( is => 'ro', isa => 'Str', required => 1 );
diff --git a/lib/Git/PurePerl/Config.pm b/lib/Git/PurePerl/Config.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::Config;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 extends 'Config::GitLike';
 
diff --git a/lib/Git/PurePerl/DirectoryEntry.pm b/lib/Git/PurePerl/DirectoryEntry.pm
@@ -2,17 +2,17 @@ package Git::PurePerl::DirectoryEntry;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 has 'mode'     => ( is => 'ro', isa => 'Str',           required => 1 );
 has 'filename' => ( is => 'ro', isa => 'Str',           required => 1 );
 has 'sha1'     => ( is => 'ro', isa => 'Str',           required => 1 );
 has 'git'      => ( is => 'ro', isa => 'Git::PurePerl', required => 1 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub object {
     my $self = shift;
     return $self->git->get_object( $self->sha1 );
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Loose.pm b/lib/Git/PurePerl/Loose.pm
@@ -4,6 +4,7 @@ use MooseX::StrictConstructor;
 use MooseX::Types::Path::Class;
 use Compress::Zlib qw(compress uncompress);
 use Path::Class;
+use namespace::autoclean;
 
 has 'directory' => (
     is       => 'ro',
@@ -12,8 +13,6 @@ has 'directory' => (
     coerce   => 1
 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub get_object {
     my ( $self, $sha1 ) = @_;
 
@@ -58,4 +57,5 @@ sub all_sha1s {
     );
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/NewDirectoryEntry.pm b/lib/Git/PurePerl/NewDirectoryEntry.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::NewDirectoryEntry;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 has 'mode'     => ( is => 'ro', isa => 'Str',           required => 1 );
 has 'filename' => ( is => 'ro', isa => 'Str',           required => 1 );
diff --git a/lib/Git/PurePerl/NewObject.pm b/lib/Git/PurePerl/NewObject.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::NewObject;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 enum 'ObjectKind' => qw(commit tree blob tag);
 
@@ -10,8 +11,6 @@ has 'size' => ( is => 'ro', isa => 'Int', required => 0, lazy_build => 1 );
 has 'content' => ( is => 'rw', isa => 'Str', required => 0, lazy_build => 1 );
 has 'sha1'    => ( is => 'ro', isa => 'Str', required => 0, lazy_build => 1 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub _build_sha1 {
     my $self = shift;
     my $sha1 = Digest::SHA1->new;
@@ -30,4 +29,5 @@ sub raw {
     return $self->kind . ' ' . $self->size . "\0" . $self->content;
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/NewObject/Blob.pm b/lib/Git/PurePerl/NewObject/Blob.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::NewObject::Blob;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::NewObject';
 
 has 'kind' =>
diff --git a/lib/Git/PurePerl/NewObject/Commit.pm b/lib/Git/PurePerl/NewObject/Commit.pm
@@ -3,6 +3,8 @@ use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
 use DateTime;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::NewObject';
 
 has 'kind' =>
@@ -16,8 +18,6 @@ has 'committer' =>
 has 'committed_time' => ( is => 'rw', isa => 'DateTime', required => 1 );
 has 'comment'        => ( is => 'rw', isa => 'Str',      required => 1 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub _build_content {
     my $self = shift;
     my $content;
@@ -47,4 +47,5 @@ sub _build_content {
     $self->content($content);
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/NewObject/Tag.pm b/lib/Git/PurePerl/NewObject/Tag.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::NewObject::Tag;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::NewObject';
 
 has 'kind' =>
diff --git a/lib/Git/PurePerl/NewObject/Tree.pm b/lib/Git/PurePerl/NewObject/Tree.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::NewObject::Tree;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::NewObject';
 
 has 'kind' =>
@@ -13,8 +15,6 @@ has 'directory_entries' => (
     auto_deref => 1,
 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub _build_content {
     my $self = shift;
     my $content;
@@ -27,4 +27,5 @@ sub _build_content {
     $self->content($content);
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Object.pm b/lib/Git/PurePerl/Object.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::Object;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
 
 enum 'ObjectKind' => qw(commit tree blob tag);
 
diff --git a/lib/Git/PurePerl/Object/Blob.pm b/lib/Git/PurePerl/Object/Blob.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::Object::Blob;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Object';
 
 has 'kind' =>
diff --git a/lib/Git/PurePerl/Object/Commit.pm b/lib/Git/PurePerl/Object/Commit.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::Object::Commit;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Object';
 
 has 'kind' =>
@@ -15,8 +17,6 @@ has 'committer' =>
 has 'committed_time' => ( is => 'rw', isa => 'DateTime', required => 0 );
 has 'comment'        => ( is => 'rw', isa => 'Str',      required => 0 );
 
-__PACKAGE__->meta->make_immutable;
-
 my %method_map = (
     'tree'      => 'tree_sha1',
     'parent'    => '_push_parent_sha1',
@@ -79,4 +79,5 @@ sub parents {
     return map { $self->git->get_object( $_ ) } @{$self->parent_sha1s};
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Object/Tag.pm b/lib/Git/PurePerl/Object/Tag.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::Object::Tag;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Object';
 
 has 'kind' =>
@@ -14,9 +16,6 @@ has 'comment' => ( is => 'rw', isa => 'Str', required => 0 );
 has 'object_kind' =>
     ( is => 'rw', isa => 'ObjectKind', required => 0);
 
-
-__PACKAGE__->meta->make_immutable;
-
 my %method_map = (type => 'object_kind');
 
 sub BUILD {
@@ -43,4 +42,5 @@ sub BUILD {
     $self->comment( join "\n", @lines );
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Object/Tree.pm b/lib/Git/PurePerl/Object/Tree.pm
@@ -2,6 +2,8 @@ package Git::PurePerl::Object::Tree;
 use Moose;
 use MooseX::StrictConstructor;
 use Moose::Util::TypeConstraints;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Object';
 
 has 'kind' =>
@@ -13,8 +15,6 @@ has 'directory_entries' => (
     auto_deref => 1,
 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub BUILD {
     my $self    = shift;
     my $content = $self->content;
@@ -40,4 +40,5 @@ sub BUILD {
     $self->directory_entries( \@directory_entries );
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Pack.pm b/lib/Git/PurePerl/Pack.pm
@@ -4,13 +4,12 @@ use MooseX::StrictConstructor;
 use MooseX::Types::Path::Class;
 use Compress::Raw::Zlib;
 use IO::File;
+use namespace::autoclean;
 
 has 'filename' =>
     ( is => 'ro', isa => 'Path::Class::File', required => 1, coerce => 1 );
 has 'fh' => ( is => 'rw', isa => 'IO::File', required => 0 );
 
-__PACKAGE__->meta->make_immutable;
-
 my @TYPES = ( 'none', 'commit', 'tree', 'blob', 'tag', '', 'ofs_delta',
     'ref_delta' );
 my $OBJ_NONE      = 0;
@@ -206,6 +205,5 @@ sub patch_delta_header_size {
     return ( $size, $pos );
 }
 
+__PACKAGE__->meta->make_immutable;
 
-
-1;
diff --git a/lib/Git/PurePerl/Pack/WithIndex.pm b/lib/Git/PurePerl/Pack/WithIndex.pm
@@ -1,15 +1,15 @@
 package Git::PurePerl::Pack::WithIndex;
 use Moose;
 use MooseX::StrictConstructor;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Pack';
 
 has 'index_filename' =>
     ( is => 'rw', isa => 'Path::Class::File', required => 0, coerce => 1 );
 has 'index' =>
     ( is => 'rw', isa => 'Git::PurePerl::PackIndex', required => 0 );
 
-__PACKAGE__->meta->make_immutable;
-
 sub BUILD {
     my $self = shift;
     my $index_filename = $self->filename;
@@ -49,4 +49,5 @@ sub get_object {
     return $self->unpack_object($offset);
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/Pack/WithoutIndex.pm b/lib/Git/PurePerl/Pack/WithoutIndex.pm
@@ -1,12 +1,12 @@
 package Git::PurePerl::Pack::WithoutIndex;
 use Moose;
 use MooseX::StrictConstructor;
+use namespace::autoclean;
+
 extends 'Git::PurePerl::Pack';
 
 has 'offsets' => ( is => 'rw', isa => 'HashRef', required => 0 );
 
-__PACKAGE__->meta->make_immutable;
-
 my @TYPES = ( 'none', 'commit', 'tree', 'blob', 'tag', '', 'ofs_delta',
     'ref_delta' );
 
@@ -116,4 +116,5 @@ sub get_object {
     return $self->unpack_object($offset);
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/PackIndex.pm b/lib/Git/PurePerl/PackIndex.pm
@@ -2,6 +2,7 @@ package Git::PurePerl::PackIndex;
 use Moose;
 use MooseX::StrictConstructor;
 use IO::File;
+use namespace::autoclean;
 
 has 'filename' =>
     ( is => 'ro', isa => 'Path::Class::File', required => 1, coerce => 1 );
@@ -12,8 +13,6 @@ has 'offsets' =>
     ( is => 'rw', isa => 'ArrayRef[Int]', required => 0, auto_deref => 1, );
 has 'size' => ( is => 'rw', isa => 'Int', required => 0 );
 
-__PACKAGE__->meta->make_immutable;
-
 my $FanOutCount   = 256;
 my $SHA1Size      = 20;
 my $IdxOffsetSize = 4;
@@ -43,4 +42,5 @@ sub BUILD {
     $self->size( $offsets[-1] );
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/PackIndex/Version1.pm b/lib/Git/PurePerl/PackIndex/Version1.pm
@@ -1,9 +1,9 @@
 package Git::PurePerl::PackIndex::Version1;
 use Moose;
 use MooseX::StrictConstructor;
+use namespace::autoclean;
 
 extends 'Git::PurePerl::PackIndex';
-__PACKAGE__->meta->make_immutable;
 
 my $FanOutCount   = 256;
 my $SHA1Size      = 20;
@@ -68,4 +68,5 @@ sub get_object_offset {
     return;
 }
 
-1;
+__PACKAGE__->meta->make_immutable;
+
diff --git a/lib/Git/PurePerl/PackIndex/Version2.pm b/lib/Git/PurePerl/PackIndex/Version2.pm
diff --git a/lib/Git/PurePerl/Protocol.pm b/lib/Git/PurePerl/Protocol.pm
