Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eligible networks for QF matching logos spill over the bounds of the project details box when there are 11 eligible networks #4979

Open
2 tasks
laurenluz opened this issue Jan 28, 2025 · 4 comments
Labels
bug Something isn't working QF Quadratic Funding Related

Comments

@laurenluz
Copy link
Member

laurenluz commented Jan 28, 2025

Looks a bit messy, I think either they need to be smaller icons to fit in this case, or spill onto 2 lines

Image

@divine-comedian

To test:

  1. Create QF Round
  2. Enable all networks as eligible donation chains
  3. check donation matching info card on project details page (next to banner image)

AC

  • chain logos should not overflow the component bounds
  • if the chains don't fit on one line then it is broken into two lines and does not overflow component bounds
@laurenluz laurenluz added bug Something isn't working QF Quadratic Funding Related labels Jan 28, 2025
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 28, 2025
@laurenluz laurenluz moved this from New Issues to Product Backlog in All-Devs Jan 28, 2025
@divine-comedian

This comment has been minimized.

@Tosinolawale
Copy link

Tosinolawale commented Jan 28, 2025

@divine-comedian
Copy link
Contributor

@LatifatAbdullahi - this fix should be good to check on production

you can test it here -> https://giveth.io/project/defend-roman-storm

@LatifatAbdullahi
Copy link

Test Update @divine-comedian

  • Chain logos should not overflow the component bounds - Pass

  • If the chains don't fit on one line then it is broken into two lines and does not overflow component bounds - Pass

Image

@LatifatAbdullahi LatifatAbdullahi moved this from Product Backlog to Done in All-Devs Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

4 participants