Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove estimated matching from staging #4986

Open
4 tasks done
kkatusic opened this issue Jan 29, 2025 · 7 comments
Open
4 tasks done

Remove estimated matching from staging #4986

kkatusic opened this issue Jan 29, 2025 · 7 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@kkatusic
Copy link
Collaborator

kkatusic commented Jan 29, 2025

Before we decide will estimated matching is going on in one of the releases, we need to remove it.

Related branches are:

PRs:


This issue is to confirm we correctly REMOVED any features related to updating the estimated matching

Image

AC

testing on staging branch we should NOT see any views related to estimated matching

  • while on the donate page for a project inside qf round, when selecting amount to donate, no estimated matching amount should pop-up above the input box
  • no tooltip should show related to the timer for when the next update to estimated matching should occur
  • estimated matching amounts shown on the project details page next to banner and next to project donations table on project details page show same estimated matching amount
  • project card estimated matching is same as shown on project details page for same project.
@kkatusic kkatusic self-assigned this Jan 29, 2025
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jan 29, 2025
@kkatusic kkatusic moved this from New Issues to Research & Planning in All-Devs Jan 29, 2025
@kkatusic kkatusic moved this from Research & Planning to Code Review/PR in All-Devs Jan 30, 2025
@divine-comedian
Copy link
Contributor

@kkatusic does this need QA or can we all this done?

@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Feb 4, 2025
@kkatusic
Copy link
Collaborator Author

kkatusic commented Feb 4, 2025

@kkatusic does this need QA or can we all this done?

@divine-comedian I merged PR need to be tested did I remove from all layouts.

@divine-comedian divine-comedian added the QF Quadratic Funding Related label Feb 4, 2025
@divine-comedian
Copy link
Contributor

@maryjaf can you test this one - we should be checking features have been successfully REMOVED regarding estimated matching updates

@maryjaf
Copy link
Collaborator

maryjaf commented Feb 4, 2025

  • while on the donate page for a project inside qf round, when selecting amount to donate, no estimated matching amount should pop-up above the input box[x] no tooltip should show related to the timer for when the next update to estimated matching should occur[x] estimated matching amounts shown on the project details page next to banner and next to project donations table on project details page show same estimated matching amount[x] project card estimated matching is same as shown on project details page for same project

These ACs have been passed and all message related to updated time has been removed in tooltip and project page

but I'm not sure the estimated matching is calculated by which algorithm, I donated 10 $ and I expect the estimated matching is increased from 200$ into 250 but until now it isn't changed

@kkatusic @CarlosQ96
https://gnosisscan.io/tx/0xdbaf8823d6ef584d3d472a990b678f67dcaf471a6cdee4456ed87fc3cecdd015
https://staging.giveth.io/project/how-many-photos-is-too-many-photos?tab=donations

@kkatusic
Copy link
Collaborator Author

kkatusic commented Feb 5, 2025

@maryjaf, cc @CarlosQ96, Is there some formula that I can check? Why, I checked FE code and it is using old estimate matching, not new one. thx

@divine-comedian
Copy link
Contributor

divine-comedian commented Feb 6, 2025

@maryjaf could you test again - I tried and it seemed to update estimated matching almost instantly

https://staging.giveth.io/donate/mejan

@maryjaf
Copy link
Collaborator

maryjaf commented Feb 6, 2025

@maryjaf could you test again - I tried and it seemed to update estimated matching almost instantly

https://staging.giveth.io/donate/mejan

Yeah, I've checked and the estimated matching has been updated correctly

@maryjaf maryjaf moved this from QA to Done in All-Devs Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

3 participants