Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project cards on mobile cut off donate button #4992

Open
3 tasks
divine-comedian opened this issue Jan 30, 2025 · 6 comments
Open
3 tasks

project cards on mobile cut off donate button #4992

divine-comedian opened this issue Jan 30, 2025 · 6 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@divine-comedian
Copy link
Contributor

User reported that on mobile view for projects included in the active QF round the donate button was being cut off, making it sometimes barely visible and hard to click.

Gm congrats with the round, fam

Ux on iOS is a little weird @mitch (🍔, 🍔)
The button works though not so discoverable

Image

we should adjust the height of the card for projects in active qf round so the donate button is fully visible while on the qf/all page while there is an active qf round.

AC

  • while viewing project cards ON MOBILE for a given project inside active qf round in qf/all page cards show fully the donate button
  • when projects are not inside qf round on all/projects page ON MOBILE the card size is normally size withou excessive empty space below the donate button
  • while viewing project cards ON MOBILE for a given project inside active qf round in all/projects page cards show fully the donate button
@divine-comedian
Copy link
Contributor Author

divine-comedian commented Jan 30, 2025

this should be ready to test ON PRODUCTION

@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi

@LatifatAbdullahi LatifatAbdullahi moved this from QA to In Progress in All-Devs Feb 1, 2025
@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Feb 1, 2025

Test Update @divine-comedian

Note: Verification done on Android(Samsung S23)

  • While viewing project cards ON MOBILE for a given project inside active qf round in qf/all page cards show fully the donate button - Failed

  • When projects are not inside qf round on all/projects page ON MOBILE the card size is normally size without excessive empty space below the donate button - Pass

Issues:

  1. When the Project has "Givback" , "Vouched" and "QF" badges, the donate button is still not properly displayed on the Project cards. (Mobile View)

Image

WhatsApp.Video.2025-02-01.at.10.15.44_0a8492f0.mp4

The donate button is displayed fine, with less badges on the Project card

Image

@divine-comedian
Copy link
Contributor Author

Ah you're right, looks like with Mobile L screens it is fine but any smaller mobile screens it still gets cut off, will make a fix soon

@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi can you test this out on STAGING -

Looks like for smaller mobile screens the donate button was still being cut off, it should be resolved now.

@LatifatAbdullahi
Copy link

@divine-comedian

The issue is fixed on staging

Image

Screen_Recording_20250203_175346_Chrome.mp4

@divine-comedian divine-comedian moved this from In Progress to Done in All-Devs Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

3 participants