Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled projects should not be viewable on the DApp #5006

Open
WhyldWanderer opened this issue Feb 6, 2025 · 1 comment
Open

Cancelled projects should not be viewable on the DApp #5006

WhyldWanderer opened this issue Feb 6, 2025 · 1 comment
Labels
bug Something isn't working DAPP Issues related to the DApp or DApp WG P0 Something is broken or not working

Comments

@WhyldWanderer
Copy link

Describe the bug
'Cancelled' projects are viewable on the DApp. This leaves users vulnerable to things like phishing attacks from malicious projects that have been cancelled.

To Reproduce
You can see 3 projects that were cancelled for phishing:
https://giveth.io/project/como-usar-polygon-bridge
https://giveth.io/project/swap-crypto-with-defillama-swap
https://giveth.io/project/defillama-swap-the-best-platform-to-swap-crypto

The projects can still be seen and the phishing links in the description are still clickable.

Expected behavior
the user should see.. 'This project does not exist' or some sort of error screen instead.

Not to be confused with 'Deactivated' projects.

'Cancelled' - project should be non-existent for all users
'Deactivated' - project should still be viewable but not accepting donations.

cc @divine-comedian

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Feb 6, 2025
@WhyldWanderer WhyldWanderer added bug Something isn't working DAPP Issues related to the DApp or DApp WG P0 Something is broken or not working labels Feb 6, 2025
@divine-comedian
Copy link
Contributor

divine-comedian commented Feb 6, 2025

Yikes! That is not good

Looking at the project you mentioned I tried a few different things in the project admin setting

  • listing project then unlisting with status of cancelled
    changing status from cancelled to deactivated then back to cancelled

nothing seems to produce the expected result. the expected behaviour is that the project should not be viewable anymore on the dapp when project is cancelled.

I can see a toast message says I don't have access to view the project and I can see some typeerrors and apolloerrors in the console
Image

@divine-comedian divine-comedian moved this from New Issues to Product Backlog in All-Devs Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DAPP Issues related to the DApp or DApp WG P0 Something is broken or not working
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants