Improve issues_milestones.go coverage (google#1749)

Author: gmlewis

github/issues_milestones_test.go

@@ -40,6 +40,20 @@ func TestIssuesService_ListMilestones(t *testing.T) {
 	if !reflect.DeepEqual(milestones, want) {
 		t.Errorf("IssuesService.ListMilestones returned %+v, want %+v", milestones, want)
 	}
+
+	const methodName = "ListMilestones"
+	testBadOptions(t, methodName, func() (err error) {
+		_, _, err = client.Issues.ListMilestones(ctx, "\n", "\n", opt)
+		return err
+	})
+
+	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+		got, resp, err := client.Issues.ListMilestones(ctx, "o", "r", opt)
+		if got != nil {
+			t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+		}
+		return resp, err
+	})
 }
 
 func TestIssuesService_ListMilestones_invalidOwner(t *testing.T) {
@@ -70,6 +84,20 @@ func TestIssuesService_GetMilestone(t *testing.T) {
 	if !reflect.DeepEqual(milestone, want) {
 		t.Errorf("IssuesService.GetMilestone returned %+v, want %+v", milestone, want)
 	}
+
+	const methodName = "GetMilestone"
+	testBadOptions(t, methodName, func() (err error) {
+		_, _, err = client.Issues.GetMilestone(ctx, "\n", "\n", -1)
+		return err
+	})
+
+	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+		got, resp, err := client.Issues.GetMilestone(ctx, "o", "r", 1)
+		if got != nil {
+			t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+		}
+		return resp, err
+	})
 }
 
 func TestIssuesService_GetMilestone_invalidOwner(t *testing.T) {
@@ -109,6 +137,20 @@ func TestIssuesService_CreateMilestone(t *testing.T) {
 	if !reflect.DeepEqual(milestone, want) {
 		t.Errorf("IssuesService.CreateMilestone returned %+v, want %+v", milestone, want)
 	}
+
+	const methodName = "CreateMilestone"
+	testBadOptions(t, methodName, func() (err error) {
+		_, _, err = client.Issues.CreateMilestone(ctx, "\n", "\n", input)
+		return err
+	})
+
+	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+		got, resp, err := client.Issues.CreateMilestone(ctx, "o", "r", input)
+		if got != nil {
+			t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+		}
+		return resp, err
+	})
 }
 
 func TestIssuesService_CreateMilestone_invalidOwner(t *testing.T) {
@@ -148,6 +190,20 @@ func TestIssuesService_EditMilestone(t *testing.T) {
 	if !reflect.DeepEqual(milestone, want) {
 		t.Errorf("IssuesService.EditMilestone returned %+v, want %+v", milestone, want)
 	}
+
+	const methodName = "EditMilestone"
+	testBadOptions(t, methodName, func() (err error) {
+		_, _, err = client.Issues.EditMilestone(ctx, "\n", "\n", -1, input)
+		return err
+	})
+
+	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+		got, resp, err := client.Issues.EditMilestone(ctx, "o", "r", 1, input)
+		if got != nil {
+			t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+		}
+		return resp, err
+	})
 }
 
 func TestIssuesService_EditMilestone_invalidOwner(t *testing.T) {
@@ -172,6 +228,16 @@ func TestIssuesService_DeleteMilestone(t *testing.T) {
 	if err != nil {
 		t.Errorf("IssuesService.DeleteMilestone returned error: %v", err)
 	}
+
+	const methodName = "DeleteMilestone"
+	testBadOptions(t, methodName, func() (err error) {
+		_, err = client.Issues.DeleteMilestone(ctx, "\n", "\n", -1)
+		return err
+	})
+
+	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+		return client.Issues.DeleteMilestone(ctx, "o", "r", 1)
+	})
 }
 
 func TestIssuesService_DeleteMilestone_invalidOwner(t *testing.T) {