From 49d1e82744937c059f019c1050cb80b8ca4eae2b Mon Sep 17 00:00:00 2001 From: chety Date: Tue, 4 Jun 2019 14:33:59 +0300 Subject: [PATCH] Code refactoring in max function --- 16_exercise-solutions/03_variadic-greatest/main.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/16_exercise-solutions/03_variadic-greatest/main.go b/16_exercise-solutions/03_variadic-greatest/main.go index 3784b710..cc0cca5b 100644 --- a/16_exercise-solutions/03_variadic-greatest/main.go +++ b/16_exercise-solutions/03_variadic-greatest/main.go @@ -3,10 +3,13 @@ package main import "fmt" func max(numbers ...int) int { - var largest int - for _, v := range numbers { - if v > largest { - largest = v + if len(numbers) == 0{ + return 0 + } + largest := numbers[0] + for _, number := range numbers { + if number > largest { + largest = number } } return largest @@ -25,7 +28,7 @@ greatest := max(-200 -700) include this as your range statement for i, v := range numbers { - if v > largest || i == 0 { + if v > largest || i == 0 {"" largest = v } }