Skip to content

Please add support for testnet sepolia #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aristotll opened this issue Apr 23, 2023 · 1 comment · Fixed by #25
Closed

Please add support for testnet sepolia #24

aristotll opened this issue Apr 23, 2023 · 1 comment · Fixed by #25
Assignees
@GoodforGod
Labels
enhancement New feature or request
Milestone
v2.0.0

Comments

@aristotll
Copy link

the address is https://sepolia.etherscan.io
https://api-sepolia.etherscan.io/

from https://docs.etherscan.io/getting-started/endpoint-urls

It won't be too hard I think modify enum io.api.etherscan.model.EthNetwork and io.api.etherscan.core.impl.EtherScanApi#EtherScanApi(java.lang.String, io.api.etherscan.model.EthNetwork, java.util.function.Supplier<io.api.etherscan.executor.IHttpExecutor>, io.api.etherscan.manager.IQueueManager)
will be sufficient
@aristotll aristotll added the enhancement New feature or request label Apr 23, 2023
@aristotll
Copy link
Author

If you don't have free time, I would be happy to create the PR.

@GoodforGod GoodforGod linked a pull request May 10, 2023 that will close this issue
Add support for PolygonScan #20
Closed
@GoodforGod GoodforGod added this to the v2.0.0 milestone May 10, 2023
@GoodforGod GoodforGod linked a pull request May 13, 2023 that will close this issue
[2.0.0] #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoodforGod GoodforGod

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

[2.0.0] GoodforGod/java-etherscan-api
Add support for PolygonScan guggio/java-etherscan-api
2 participants
@GoodforGod @aristotll