Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK25 will remove Java security manager. Code cleanup... #319

Open
ludoch opened this issue Dec 5, 2024 · 2 comments
Open

JDK25 will remove Java security manager. Code cleanup... #319

ludoch opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ludoch
Copy link
Collaborator

ludoch commented Dec 5, 2024

Since Java8 new gVisor sandbox, we removed a lot of code using the obsolete java security manager.

We still have some leftover that we might want to cleanup before testing with JDK25 later in 2025.

Also code using AccessController.doPrivileged(...) should be evaluated to complete deletion of java.security imports.

@ludoch ludoch added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 5, 2024
@ludoch
Copy link
Collaborator Author

ludoch commented Dec 5, 2024

Other warnings I see is about Character class:

/appengine_standard/api_dev/src/main/java/com/google/appengine/api/search/dev/WordSeparatorAnalyzer.java:78: warning: [removal] Character(char) in Character has been deprecated and marked for removal
return !LuceneUtils.WORD_SEPARATORS.contains(new Character(c));

@ludoch
Copy link
Collaborator Author

ludoch commented Dec 18, 2024

In general, we should try to remove as much as possible build warnings like "has been deprecated and marked for removal"

Some might not be possible yet

@maigovannon maigovannon self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants