run package tests

Author: davidcavazos

.github/testing/.eslintrc.json

@@ -1,3 +1,13 @@
 {
-  "extends": "./node_modules/gts/"
+  "extends": "./node_modules/gts/",
+  "rules": {
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "caughtErrorsIgnorePattern": "^_"
+      }
+    ]
+  }
 }

.github/testing/src/affected.ts

@@ -12,27 +12,42 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { Map, List, Set } from 'immutable';
+import {Map, List, Set} from 'immutable';
 
 export type PackageName = string;
 export type TestPath = string;
 export type TestName = string;
 
-export const TestAll = (path: string): Affected => ({ path: path, TestAll: null });
-export const TestSome = (path: string, tests: Map<TestPath, Set<TestName>>): Affected => ({
+export const TestAll = (path: string): Affected => ({
+  path: path,
+  TestAll: null,
+});
+export const TestSome = (
+  path: string,
+  tests: Map<TestPath, Set<TestName>>
+): Affected => ({
   path: path,
   TestSome: tests,
 });
 export type Affected =
-  | { path: string, TestAll: null }
-  | { path: string, TestSome: Map<TestPath, Set<TestName>> };
+  | {path: string; TestAll: null}
+  | {path: string; TestSome: Map<TestPath, Set<TestName>>};
 
-export function mergeAffected(path: string, affected: List<Affected>): Affected {
-  return affected.reduce((result, current) => {
-    if ('TestSome' in result && 'TestSome' in current) {
-      const tests = result.TestSome.mergeWith((xs, ys) => xs.union(ys), current.TestSome)
-      return TestSome(path, tests);
-    }
-    return TestAll(path);
-  }, TestSome(path, Map()));
+export function mergeAffected(
+  path: string,
+  affected: List<Affected>
+): Affected {
+  return affected.reduce(
+    (result, current) => {
+      if ('TestSome' in result && 'TestSome' in current) {
+        const tests = result.TestSome.mergeWith(
+          (xs, ys) => xs.union(ys),
+          current.TestSome
+        );
+        return TestSome(path, tests);
+      }
+      return TestAll(path);
+    },
+    TestSome(path, Map())
+  );
 }

.github/testing/src/config.ts

@@ -15,23 +15,16 @@
 import * as fs from 'node:fs';
 import * as git from './git';
 import * as path from 'path';
-import { List, Map, Set } from 'immutable';
-import { minimatch } from 'minimatch'; /* eslint-disable  @typescript-eslint/no-explicit-any */
-import {
-  Affected,
-  PackageName,
-  TestAll,
-  TestName,
-  TestPath,
-  mergeAffected,
-} from './affected';
+import {List, Map, Set} from 'immutable';
+import {minimatch} from 'minimatch'; /* eslint-disable @typescript-eslint/no-explicit-any */
+import {Affected, TestAll, TestName, TestPath, mergeAffected} from './affected';
 
 export class Config {
   match: List<string>;
   ignore: List<string>;
   packageFile: List<string>;
-  testAll: (path: PackageName) => void;
-  testSome: (path: PackageName, tests: Map<TestPath, Set<TestName>>) => void;
+  testAll: () => void;
+  testSome: (tests: Map<TestPath, Set<TestName>>) => void;
 
   constructor({
     match,
@@ -43,14 +36,16 @@ export class Config {
     match?: string[];
     ignore?: string[];
     packageFile?: string[];
-    testAll?: (path: PackageName) => void;
-    testSome?: (path: PackageName, tests: Map<TestPath, Set<TestName>>) => void;
+    testAll?: () => void;
+    testSome?: (tests: Map<TestPath, Set<TestName>>) => void;
   }) {
     this.match = List(match || ['**']);
     this.ignore = List(ignore);
     this.packageFile = List(packageFile);
-    this.testAll = testAll || (path => { });
-    this.testSome = testSome || ((path, tests) => { });
+    this.testAll = testAll || (() => {});
+    this.testSome =
+      testSome ||
+      (_ => {}); /* eslint-disable @typescript-eslint/no-unused-vars */
   }
 
   affected = (head: string, main: string): List<Affected> =>
@@ -65,25 +60,27 @@ export class Config {
     );
 
   test = (affected: Affected) => {
-    const cwd = process.cwd()
-    process.chdir(git.root())
+    const cwd = process.cwd();
+    const dir = path.join(git.root(), affected.path);
+    console.log(`>> cd ${dir}`);
+    process.chdir(dir);
     if ('TestAll' in affected) {
-      this.testAll(affected.path)
+      this.testAll();
     }
     if ('TestSome' in affected) {
-      this.testSome(affected.path, affected.TestSome)
+      this.testSome(affected.TestSome);
     }
-    process.chdir(cwd)
-  }
+    process.chdir(cwd);
+  };
 
   matchFile = (diff: git.Diff): boolean =>
     this.match.some(p => minimatch(diff.filename, p)) &&
     this.ignore.some(p => !minimatch(diff.filename, p));
 
   findAffected = (diff: git.Diff): Affected => {
-    const path = this.findPackage(diff.filename)
-    return TestAll(path) // TOOD: discover affected tests only
-  }
+    const path = this.findPackage(diff.filename);
+    return TestAll(path); // TOOD: discover affected tests only
+  };
 
   findPackage = (filename: string): string => {
     const dir = path.dirname(filename);

.github/testing/src/config/python.ts

@@ -12,7 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { Config } from '../config';
+import * as subprocess from '../subprocess';
+import {Config} from '../config';
 
 export const python = new Config({
   match: ['**'],
@@ -24,10 +25,10 @@ export const python = new Config({
     'setup.py',
     'setup.cfg',
   ],
-  testAll: path => {
-    throw `TODO: config/python.ts testAll ${path}`
+  testAll: () => {
+    subprocess.run('nox', ['-s', 'py-3.11']);
+  },
+  testSome: tests => {
+    throw `TODO: config/python.ts testSome ${JSON.stringify(tests)}`;
   },
-  testSome: (path, tests) => {
-    throw `TODO: config/python.ts testSome ${path} ${JSON.stringify(tests)}`
-  }
 });

.github/testing/src/git.ts

@@ -13,32 +13,30 @@
 // limitations under the License.
 
 import { List } from 'immutable';
-import { spawnSync } from 'child_process';
+import * as subprocess from './subprocess';
 
 export type Diff = {
   filename: string;
   lineNumbers: number[];
 };
 
 export function branchName(): string {
-  const p = spawnSync('git', ['rev-parse', '--abbrev-ref', 'HEAD']);
-  return p.stdout.toString().trim();
+  return subprocess.output('git', ['rev-parse', '--abbrev-ref', 'HEAD']);
 }
 
 export function root(): string {
-  const p = spawnSync('git', ['rev-parse', '--show-toplevel']);
-  return p.stdout.toString().trim();
+  return subprocess.output('git', ['rev-parse', '--show-toplevel']);
 }
 
 export function diffs(commit1: string, commit2: string): List<Diff> {
-  const p = spawnSync('git', [
+  const output = subprocess.output('git', [
     '--no-pager',
     'diff',
     '--unified=0',
     commit1,
     commit2,
   ]);
-  return List(p.stdout.toString().split(/^diff --git a\//m))
+  return List(output.split(/^diff --git a\//m))
     .map(output => output.split('\n').filter(line => line.length > 0))
     .filter(lines => lines.length > 0)
     .map(lines => ({

.github/testing/src/main.ts

@@ -13,9 +13,9 @@
 // limitations under the License.
 
 import * as git from './git';
-import { Config } from './config';
-import { python } from './config/python';
-import { Affected } from './affected';
+import {Config} from './config';
+import {python} from './config/python';
+import {Affected} from './affected';
 
 function getConfig(lang: string): Config {
   switch (lang) {

.github/testing/src/subprocess.ts

@@ -0,0 +1,27 @@
+// Copyright 2024 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+import { spawnSync } from 'child_process';
+
+export function run(cmd: string, args: string[]) {
+  const p = spawnSync(cmd, args, { stdio: 'inherit' });
+  process.exitCode = p.status || undefined;
+}
+
+export function output(cmd: string, args: string[]): string {
+  const p = spawnSync(cmd, args);
+  process.exitCode = p.status || undefined;
+  return p.stdout.toString().trim();
+}
+

.github/workflows/test.yaml

@@ -57,6 +57,13 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: '20.x'
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - run: python --version
+      - run: pip --version
+      - run: pip install --upgrade pip
+      - run: pip install nox
       - run: npm ci
       - run: npm run build
       - run: npm run tests python "$AFFECTED"