Skip to content

Commit faf5fee

Browse files
authored
Process v741 branch with GB_PUBLIC as the empty string (#60)
* Process v741 branch with GB_PUBLIC as the empty string * Don't use GB_PUBLIC at all (it could be removed) * with 7.4.1.beta3
1 parent f5d6c95 commit faf5fee

File tree

5 files changed

+2212
-2204
lines changed

5 files changed

+2212
-2204
lines changed

.github/workflows/test.yml

+12-5
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
18-
source: ["conda-forge"]
19-
# os: ["ubuntu-latest"]
20-
# source: ["source"]
17+
# os: ["ubuntu-latest", "macos-latest", "windows-latest"]
18+
# source: ["conda-forge"]
19+
os: ["ubuntu-latest"]
20+
source: ["source"]
2121
python-version: ["3.8", "3.9", "3.10", "3.11"]
22-
graphblas-version: ["7.4.0"]
22+
graphblas-version: ["7.4.1.beta3"]
2323
steps:
2424
- name: Checkout
2525
uses: actions/checkout@v3
@@ -40,8 +40,15 @@ jobs:
4040
run: |
4141
# This isn't working! Why not?
4242
# sh suitesparse.sh refs/tags/${{ matrix.graphblas-version }}
43+
44+
# From tag
4345
curl -L https://github.com/DrTimothyAldenDavis/GraphBLAS/archive/refs/tags/v${{ matrix.graphblas-version }}.tar.gz | tar xzf -
4446
pushd GraphBLAS-${{ matrix.graphblas-version }}/build
47+
48+
# From branch
49+
# curl -L https://github.com/DrTimothyAldenDavis/GraphBLAS/tarball/${{ matrix.graphblas-version }} | tar xzf -
50+
# pushd DrTim*/build
51+
4552
echo ${CONDA_PREFIX}
4653
cmake -DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Release ..
4754
cat Makefile

suitesparse_graphblas/create_headers.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ def groupby(index, seq):
315315
"GxB",
316316
"CMPLX",
317317
"CMPLXF",
318+
"GB_GLOBAL",
318319
"GB_PUBLIC",
319320
"GB_restrict",
320321
"GRAPHBLAS_H",
@@ -364,21 +365,21 @@ def get_groups(ast):
364365

365366
seen = set()
366367
groups = {}
367-
vals = {x for x in lines if "extern GrB_Info GxB" in x} - seen
368-
vals |= {x for x in lines if "extern " in x and "GxB_Iterator" in x and "GB" not in x} - seen
368+
vals = {x for x in lines if "GrB_Info GxB" in x} - seen
369+
vals |= {x for x in lines if "GxB_Iterator" in x and "GB" not in x} - seen
369370
seen.update(vals)
370371
groups["GxB methods"] = sorted(vals, key=sort_key)
371372

372-
vals = {x for x in lines if "extern GrB_Info GrB" in x} - seen
373+
vals = {x for x in lines if "GrB_Info GrB" in x} - seen
373374
seen.update(vals)
374375
groups["GrB methods"] = sorted(vals, key=sort_key)
375376

376-
vals = {x for x in lines if "extern GrB_Info GB" in x} - seen
377-
vals |= {x for x in lines if "extern " in x and "GxB_Iterator" in x and "GB" in x} - seen
377+
vals = {x for x in lines if "GrB_Info GB" in x} - seen
378+
vals |= {x for x in lines if "GxB_Iterator" in x and "GB" in x and "typedef" not in x} - seen
378379
seen.update(vals)
379380
groups["GB methods"] = sorted(vals, key=sort_key)
380381

381-
missing_methods = {x for x in lines if "extern GrB_Info " in x} - seen
382+
missing_methods = {x for x in lines if "GrB_Info " in x} - seen
382383
assert not missing_methods, ", ".join(sorted(missing_methods))
383384

384385
vals = {x for x in lines if "extern GrB" in x} - seen
@@ -584,7 +585,7 @@ def __init__(self):
584585
self.functions = []
585586

586587
def visit_Decl(self, node):
587-
if isinstance(node.type, c_ast.FuncDecl) and node.storage == ["extern"]:
588+
if isinstance(node.type, c_ast.FuncDecl) and node.storage == []:
588589
self.functions.append(node)
589590

590591
def handle_function_node(node):

0 commit comments

Comments
 (0)