Skip to content

Fluid miner multiblock doesn't allow framed cables/pipes #3232

@endobson

Description

@endobson

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

What ever is in Monifactory 0.12.6

Minecraft Version

1.20.1 Forge

Recipe Viewer Installed

None

Environment

Singleplayer

Cross-Mod Interaction

Unsure

Other Installed Mods

I was playing Monifactory but read the source code to validate the behavior.

Expected Behavior

I was using large miners and found that framed pipes were allowed in the frame slots of the multiblock. I expected that to work the same for large fluid drillers.

Actual Behavior

Fluid driller multiblock will not form if the frame block is a framed pipe.

Steps to Reproduce

Try to add pipe to built large fluid driller and observe that multiblock does not stay built.

Additional Information

I believe it is because the fluid multiblock definition does not use the frames helper that is documented for this purpose.

/**
* Use this predicate for Frames in your Multiblock. Allows for Framed Pipes as well as normal Frame blocks.
*/
public static TraceabilityPredicate frames(Material... frameMaterials) {

The frame block in fluid drillers:

.where('F', blocks(FluidDrillMachine.getFrameState(tier)))

The frame block in large miners:

.where('F', frames(LargeMinerMachine.getMaterial(tier)))

(Also please allow bug reports where I don't have to lie about validating this in the most recent version).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions