Skip to content

Conversation

@brtnfld
Copy link
Collaborator

@brtnfld brtnfld commented Nov 26, 2025

Remove premature flag assignment and derive H5_HAVE_C99_COMPLEX_NUMBERS
deterministically from cached type sizes instead of caching the flag.
Fixes re-configuration failures and eliminates cache pollution.

Also fixes typo checking _FCOMPLEX twice instead of _LCOMPLEX.

Fixes #6051


Important

Fix C99 complex detection in ConfigureChecks.cmake by removing premature flag assignment and fixing MSVC type check typo.

  • Behavior:
    • Remove premature assignment of H5_HAVE_C99_COMPLEX_NUMBERS in ConfigureChecks.cmake.
    • Derive H5_HAVE_C99_COMPLEX_NUMBERS from cached type sizes instead of caching the flag.
    • Fixes re-configuration failures and eliminates cache pollution.
  • Bug Fixes:
    • Fix typo in MSVC complex type check: check _LCOMPLEX instead of _FCOMPLEX twice.

This description was created by Ellipsis for f7b377f. You can customize this summary. It will automatically update as commits are pushed.

@brtnfld brtnfld marked this pull request as draft November 26, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To be triaged

Development

Successfully merging this pull request may close these issues.

MSVC build fails on CMake re-configure due to cached C99 complex type size (Cache pollution)

1 participant