Fix CMake C99 complex detection cache pollution #6061
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove premature flag assignment and derive H5_HAVE_C99_COMPLEX_NUMBERS
deterministically from cached type sizes instead of caching the flag.
Fixes re-configuration failures and eliminates cache pollution.
Also fixes typo checking _FCOMPLEX twice instead of _LCOMPLEX.
Fixes #6051
Important
Fix C99 complex detection in
ConfigureChecks.cmakeby removing premature flag assignment and fixing MSVC type check typo.H5_HAVE_C99_COMPLEX_NUMBERSinConfigureChecks.cmake.H5_HAVE_C99_COMPLEX_NUMBERSfrom cached type sizes instead of caching the flag._LCOMPLEXinstead of_FCOMPLEXtwice.This description was created by
for f7b377f. You can customize this summary. It will automatically update as commits are pushed.