Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging fails on "invalid relative path" #45

Closed
DvvCz opened this issue Aug 30, 2023 · 5 comments
Closed

Packaging fails on "invalid relative path" #45

DvvCz opened this issue Aug 30, 2023 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers wontfix This will not be worked on

Comments

@DvvCz
Copy link

DvvCz commented Aug 30, 2023

publish-vscode-extension Version Operating System
v1 ubuntu-latest

Description

Action fails on packaging my extension because of my editorconfig file?
The invalid relative path it gives me in the error is referenced nowhere in my project. It's just a .editorconfig file at the top level of my monorepo.
I've tried duplicating the .editorconfig file and putting it inside of the folder to be uploaded, but didn't do anything.
Then I assumed it was because I had no vscodeignore file, seems that didn't do anything either.

Expected Behavior

Should not error

Actual Behavior

Errors on "invalid relative path" due to editorconfig (see context)

Steps to Reproduce

  1. Monorepo with packages/xyz-vscode
  2. Have .editorconfig at top level
  3. Try and package ./packages/xyz-vscode to OpenVSX

Context


Error: invalid relative path: extension/../../.editorconfig
at validateMetadataPath (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:109295:59)
at ZipFile.addFile (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:108951:18)
at /home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:4806:19
at Array.forEach ()
at /home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:4802:15
at new Promise ()
at /home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:4800:21
at async pack (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:4870:5)
at async packageCommand (/home/runner/work/_actions/HaaLeo/publish-vscode-extension/v1/dist/index.js:4880:36)

@HaaLeo HaaLeo added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 18, 2023
@YMC-GitHub
Copy link

I meet this.

@YMC-GitHub
Copy link

@DvvCz do you have an anwser ?

@DvvCz
Copy link
Author

DvvCz commented May 19, 2024

Unfortunately not. This is the last run I had with the extension: https://github.com/DvvCz/ramattra/actions/runs/6021530472

AFAIK I just left it alone to work on other parts of the project

@YMC-GitHub
Copy link

@DvvCz i found a anwser in here. microsoft/vscode-vsce#300
eg :vsce package --yarn

@HaaLeo
Copy link
Owner

HaaLeo commented May 21, 2024

I guess with that reference we can consider this as fixed or more to be an upstream problem. Thx @YMC-GitHub for digging into this.

@HaaLeo HaaLeo closed this as completed May 21, 2024
@HaaLeo HaaLeo added wontfix This will not be worked on and removed help wanted Extra attention is needed labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants