Commit 5dc6ba0
Address PR igerber#344 CI review R3 P3: clarify rank_control_units synthetic_weight docstring
Docstring at prep.py:841 now states synthetic_weight is an informational
heuristic from a single-pass uncentered Frank-Wolfe solve, does NOT factor
into quality_score ranking, and is NOT the canonical SDID unit weight.
Directs users who want canonical SDID weights to SyntheticDiD.fit().
Aligns the public contract with the implementation notes already added in
the prior round.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 3e63058 commit 5dc6ba0
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
841 | | - | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
842 | 845 | | |
843 | 846 | | |
844 | 847 | | |
| |||
0 commit comments