Update the twitter logo to X #71
Conversation
There was a problem hiding this comment.
@MestiriBaha
You have not provided the issue number but I believe you are trying to submit a PR to issue #16
How is it that you have not noticed that the issue is first of all
- assigned to someone already
and secondly - has a pretty big label with a stop sign stating that there is a prerequisite missing ?
I will close the PR since this issue has an assignee already, it has a clear label and also:
- we are not just updating a single dependency, the team is already working on Feature: Update angular and dependencies to 17.3.0 #68 updating all the dependencies.
If you would like to contribute I strongly encourage you to - instead of saying that there is information missing that is preventing you from following the CONTRIBUTING guide, you actually look at the information that has been provided first and do not take the issue in the first place when it's not available.
If the issue was available it would have been labeled with either bug or feature or another appropriate label. This information is not needed for the branch name, so it was not an obstacle in any way. The information is needed for the commit message.
And I encourage you to ask for any information that you feel is missing in a comment before submitting a PR.
|
@MestiriBaha I have mentioned your PR in the closing PR #73 because I wanted to note your involvement and acknowledge that you have worked on the issue. Please make sure to keep your forked repo updated after changes |
|
@cleancodecraft , Thank you for clarifying ! about not noticing that the issue has already an assignee , I just was so excited to contribute and I felt it was an easy task so I just rush for it ! next time , I will be more attentive about the labels , I appreciate your efforts and I won't hesitate to ask you for any information before submitting a PR 🙂 |
This PR Closes Issue
closes #
Description
I updated the Twitter logo to "X," which is included in the latest PrimeIcons version. Therefore, I updated the package.json file to the latest versions of PrimeNG and PrimeIcons. This is my first time contributing to an open-source project, and I enjoyed working on these issues. However, for this particular issue , there was no defined issue type, so I couldn't follow the contributing guidelines exactly in the branch name
What type of PR is this? (check all applicable)
Mobile & Desktop Screenshots/Recordings
Mobile Version Screenshot :
Desktop Version Screenshot :
Steps to QA
Added to documentation?
[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]