Replicated versioned collapsing merge tree #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelloSunilSaini
changed the title
ggunjan2103
reviewed
Mar 3, 2023
| if(parameterArray != null && parameterArray.length >= 4) { | ||
| versionColumn = parameterArray[3].trim(); | ||
| } | ||
| } |
ggunjan2103
reviewed
Mar 3, 2023
| ps.setInt(signColumnIndex, -1); | ||
| } else if (record.getCdcOperation().getOperation().equalsIgnoreCase(ClickHouseConverter.CDC_OPERATION.UPDATE.getOperation())){ | ||
| if(beforeSection == true) { | ||
| ps.setInt(signColumnIndex, - 1); |
There was a problem hiding this comment.
do we get before in case of incremental snapshot, in case the data is already present as part of CDC ? How is that handled ?
ggunjan2103
reviewed
Mar 3, 2023
| @@ -34,7 +34,7 @@ public String createAlterTableSyntax(String tableName, Map<String, String> colNa | |||
| } else { | |||
| alterTableSyntax.append(ClickHouseDbConstants.ALTER_TABLE_DELETE_COLUMN).append(" "); | |||
| } | |||
| alterTableSyntax.append("`").append(entry.getKey()).append("`").append(" ").append(entry.getValue()).append(","); | |||
| alterTableSyntax.append("`").append(entry.getKey()).append("`").append(" Nullable(").append(entry.getValue()).append("),"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.