Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busycontacts 2024.3.1-2024-09-18-11-17 #185945

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

antonio-caceres
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


Hey, it's my first PR to Homebrew so let me know if anything is wrong.

I tried doing brew bump --open-pr busycontacts and I got a response that the cask was up to date because the major version number matches. (I also got an API error since I don't have a Homebrew access token set up, but I assumed it would not create a PR because it thinks the cask is up to date, so I made one manually.) As of the time of this PR, the link https://www.busymac.com/download/bct-2024.3.1.zip now downloads a file bct-2024.3.1-2024-09-18-11-17.zip with a different hash that I've updated.

I've also made the changes on my machine and everything seems to work well.

@bevanjkay
Copy link
Member

Thank you @antonio-caceres - we may need to look at updating the livecheck, but it may require a second network call to check the headers of the url to get the second version part. In the past the vendor has not kept this URLs consistent.
Merging this to unblock the cask, but some further work may be required.

CC: @samford
Reverting #176374 might solve the issue, but this stopped working once before.

@bevanjkay bevanjkay merged commit 82e0c62 into Homebrew:master Sep 19, 2024
8 checks passed
@samford samford mentioned this pull request Sep 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants