Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scope detection to all packages #1410

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

SMillerDev
Copy link
Member

Rework of #1006 now that there is more linux support for casks.

@SMillerDev SMillerDev marked this pull request as draft February 23, 2025 14:05
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Mar 18, 2025
@SMillerDev SMillerDev marked this pull request as ready for review March 18, 2025 08:50
@SMillerDev
Copy link
Member Author

Since this doesn't change any behaviour, let's merge this and I'll build on it in a new review to check cask changes.

@github-actions github-actions bot removed the stale label Mar 18, 2025
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine! Need to revert/fix if it ends up trying to install casks in third party tap CI.

@SMillerDev SMillerDev merged commit a78625b into master Mar 18, 2025
7 checks passed
@SMillerDev SMillerDev deleted the feat/packages_detect/add_general_detection branch March 18, 2025 09:01
@carlocab
Copy link
Member

Looks like this causes

Error: Parameter 'file': Expected type Pathname, got type String with value "Formula/s/systemd.rb"
Caller: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:233
Definition: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:1200 (AbstractCoreTap#formula_file_to_name)
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/configuration.rb:296:in `call_validation_error_handler_default'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/configuration.rb:303:in `call_validation_error_handler'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/private/methods/call_validation.rb:322:in `report_error'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/private/methods/call_validation.rb:230:in `block in validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/private/methods/signature.rb:213:in `each_args_value_type'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/private/methods/call_validation.rb:227:in `validate_call'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/gems/sorbet-runtime-0.5.11933/lib/types/private/methods/_methods.rb:277:in `block in _on_method_added'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:233:in `block in diff_packages'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `filter_map'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `diff_packages'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:137:in `detect_packages!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:19:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:205:in `run_tests'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:67:in `block in run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:55:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:55:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_bot.rb:147:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/cmd/test-bot.rb:125:in `run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

https://github.com/Homebrew/homebrew-core/actions/runs/13920934639/job/38953815106#step:4:29

@gromgit
Copy link

gromgit commented Mar 18, 2025

Getting similar errors on my third-party tap...

Error: undefined method `basename' for an instance of String
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/tap.rb:1099:in `formula_file_to_name'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:233:in `block in diff_packages'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `filter_map'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:231:in `diff_packages'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:135:in `detect_packages!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/tests/packages_detect.rb:19:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:205:in `run_tests'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:67:in `block in run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:55:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_runner.rb:55:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/lib/test_bot.rb:147:in `run!'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-test-bot/cmd/test-bot.rb:125:in `run'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'

https://github.com/gromgit/homebrew-dev/actions/runs/13919301458/job/38948756101?pr=27#step:7:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants