-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scope detection to all packages #1410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Since this doesn't change any behaviour, let's merge this and I'll build on it in a new review to check cask changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fine! Need to revert/fix if it ends up trying to install casks in third party tap CI.
Looks like this causes
https://github.com/Homebrew/homebrew-core/actions/runs/13920934639/job/38953815106#step:4:29 |
Getting similar errors on my third-party tap...
https://github.com/gromgit/homebrew-dev/actions/runs/13919301458/job/38948756101?pr=27#step:7:19 |
Rework of #1006 now that there is more linux support for casks.