Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Commit 313caaa

Browse files
authored
fix: LEAP-724: Fix Textarea required + skipDuplicates (#1705)
* Adjust test to fail with required + skipDuplicates * Fix test to really see the problem * Run only this test for now * Rename validateValue in Textarea to fix validation This method is used to validate text when it's added by user, not to validate the entire value of Textarea result, it has different signature. We could adjust it to validate duplicated texts on submit, but that's improvement and we need just a fix right now. * Return all tests * Unrelated doc for displayMode param + fix FF comment * Fix linting and line endings in some tests ocr + textarea.skip-duplicates * Fix Textarea editing * One more missed thing
1 parent fc89cc1 commit 313caaa

File tree

6 files changed

+544
-538
lines changed

6 files changed

+544
-538
lines changed

e2e/tests/ocr.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Scenario('Drawing multiple blank regions and then attaching labels', async ({ I,
154154
'ff_front_1170_outliner_030222_short': true,
155155
});
156156
I.amOnPage('/');
157-
LabelStudio.init({ config: createConfig( ), data });
157+
LabelStudio.init({ config: createConfig(), data });
158158
AtImageView.waitForImage();
159159
AtSettings.open();
160160
AtSettings.setGeneralSettings({
@@ -192,12 +192,12 @@ Scenario('Drawing multiple blank regions and then attaching labels', async ({ I,
192192
}
193193
session('Deserialization', () => {
194194
I.amOnPage('/');
195-
LabelStudio.init({ config: createConfig( ), data, annotations: [{ id: 'test', result: results }] });
195+
LabelStudio.init({ config: createConfig(), data, annotations: [{ id: 'test', result: results }] });
196196
AtImageView.waitForImage();
197197
AtOutliner.seeRegions(regions.length);
198198
for (const [idx, region] of Object.entries(regions)) {
199199
if (region.text) {
200-
I.seeInField(AtOutliner.locateRegionIndex((+idx)+1).find('.lsf-textarea-tag__input'), region.text);
200+
I.seeInField(AtOutliner.locateRegionIndex((+idx) + 1).find('.lsf-textarea-tag__input'), region.text);
201201
}
202202
}
203203
});

0 commit comments

Comments
 (0)