address review comments

Signed-off-by: sathvik-allundi007 <[email protected]>

Author: Sathvik-Allundi-IBM

fotobox/README.md

@@ -1,12 +1,12 @@
 # IBM Fotobox
 
-This is the IBM Fotobox. Deploy your own Fotobox straight to the IBM Cloud Access it directly from any device with browser and camera. Take Pictures and view them all from your device. 
+This is the IBM Fotobox. Deploy your own Fotobox straight to the IBM Cloud access it directly from any device with browser and camera. Take pictures and view them all from your device.
 
 The solution is based on:
-- The frontend a Svelte Single Page Application running as a App on Code Engine able to scale to 0 in oder to optimise cost.
-- The Upload function which generates a thumbnail of the image and stores both in COS written in Python and running as a Function on Code Engine.
-- The Downloader a Go programm designed to serve the images stored in COS or download all at one go if you are the operator of the fotobox.
-- All Images are stored in IBM Cloud Object Storage to ensure security and scalability. 
+- The "frontend" a Svelte Single Page Application(SPA) running as a Code Engine app, that is able to scale to 0 in oder to optimise cost.
+- The "upload" function which generates a thumbnail of the image and stores both in COS written in Python and running as a Code Engine function.
+- The "downloader" a Go program designed to serve the images stored in COS or download all at one go if you are the operator of the fotobox.
+- All images are stored in IBM Cloud Object Storage to ensure security and scalability.
 
 ## Setup
 
@@ -21,28 +21,28 @@ already installed) and make sure you have a IBM Cloud Account:
 
 ## Automated Setup
 
-In order to make the setup as convinent as possible we probide you with a setupscript which uses teraform and the IBM Cloud CLI
+In order to make the setup as convenient as possible we probide you with a setup script which uses terraform and the IBM Cloud CLI
 
-1. configure the `terraform.auto.tfvars` with your apikey and your resource group id 
+1. Configure the `terraform.auto.tfvars` with your apikey and your resource group id
 
-2. Run the `setup.sh <apikey>`and it will deploy all the required components and done
+2. Run the `setup.sh <apikey>` and it will deploy all the required components and done
 
 ## Manual setup
 
-1. Setup COS with cos bucket this can be done over the UI or using the CLI  
+1. Setup a COS instance and a COS bucket this can be done over the UI or using the CLI
     note dont the bucket name and API credentials
 
-2. Deploy the Upload Function using the CLI
+2. Deploy the "upload" function using the CLI
     ```bash
     ibmcloud ce fn create --name fotobox-cos-upload  --runtime python  --build-source upload-function
     ```
 
-3. Deploy the Download App using the CLI
+3. Deploy the "download" app using the CLI
     ```bash
     ibmcloud ce app create --name fotobox-get-pics --build-dockerfile Dockerfile  --build-source download-app
     ```
 
-4. Create a Secret map containing the following values. use the following command to create the password
+4. Create a secret map containing the following values. Use the following command to create the password
     ```bash
     echo -n "password" | sha256
     5e884898da28047151d0e56f8dc6292773603d0d6aabbdd62a11ef721d1542d8
@@ -72,4 +72,4 @@ export const downloadURL = "<replace with download app url"
 ibmcloud ce app create --name fotobox-frontend --build-dockerfile Dockerfile  --build-source frontend-app
 ```
 
-Now the Fotobox should be deployed and usable
+Now the Fotobox should be deployed and usable

fotobox/cos-setup/main.tf

@@ -18,7 +18,7 @@ locals {
   resource_credentials =jsondecode(ibm_resource_key.cos-credentials.credentials_json)
 }
 
-# create cos-but to upload 
+# create cos-but to upload
 resource "ibm_cos_bucket" "cos_bucket" {
   bucket_name = "fotobox-bucket"
   resource_instance_id = ibm_resource_instance.cos_instance.id
@@ -39,23 +39,12 @@ resource "ibm_code_engine_secret" "fotobox-secret" {
   project_id = ibm_code_engine_project.ce-fotobox-project.id
   name = "fotobox-secret"
   format = "generic"
-  
+
   data = {
     "apikey" = local.resource_credentials.apikey
   }
 }
 
-#resource "ibm_code_engine_secret" "registry_secret" {
-#  project_id = ibm_code_engine_project.ce-fotobox-project.id
-#  name       = "container-registry-secret"
-#  format = "registry"
-#  data = {
-#    "username" = "iamapikey" # Use 'iamapikey' as username for IBM Cloud
-#    "password" = var.icr_secret
-#    "server"   = "us.icr.io" # Change if using a different registry
-#  }
-#}
-
 # create config map in project
 
 resource "ibm_code_engine_config_map" "fotobox-config" {
@@ -69,4 +58,4 @@ resource "ibm_code_engine_config_map" "fotobox-config" {
     "region" = ibm_cos_bucket.cos_bucket.region_location
     "resource_instance_id" = local.resource_credentials.resource_instance_id
   }
-}
+}

fotobox/download-app/Dockerfile

@@ -1,8 +1,4 @@
-FROM  golang:1.23
-
-
-# Build the application from source
-FROM --platform=linux/amd64 golang:1.23 AS build-stage
+FROM  registry.access.redhat.com/ubi9/go-toolset:1.24 AS build-stage
 
 WORKDIR /app
 
@@ -15,17 +11,12 @@ RUN CGO_ENABLED=0 GOOS=linux go build -o /api
 
 
 # Deploy the application binary into a lean image
-FROM --platform=linux/amd64 alpine
-
-
+FROM gcr.io/distroless/static:latest
 
 WORKDIR /
 
-RUN mkdir images
 COPY --from=build-stage /api /api
 
-
 EXPOSE 8080
 
-
-ENTRYPOINT ["/api"]
+ENTRYPOINT ["/api"]

fotobox/frontend-app/Dockerfile

@@ -1,4 +1,4 @@
-FROM --platform=linux/amd64 node:22 as build
+FROM egistry.access.redhat.com/ubi9/nodejs-22:latest as build
 
 WORKDIR /app
 
@@ -7,7 +7,7 @@ COPY . .
 RUN npm install && npm run build
 
 
-FROM --platform=linux/amd64 node:22
+FROM gcr.io/distroless/nodejs22
 
 WORKDIR /app