Skip to content

Commit cb9e60a

Browse files
committed
admin ui fixes
Signed-off-by: Shoumi <[email protected]>
1 parent 15e118d commit cb9e60a

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

mcpgateway/alembic/versions/k5e6f7g8h9i0_add_structured_logging_tables.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
# revision identifiers, used by Alembic.
1212
revision = 'k5e6f7g8h9i0'
13-
down_revision = 'f3a3a3d901b8'
13+
down_revision = ('f3a3a3d901b8', '191a2def08d7')
1414
branch_labels = None
1515
depends_on = None
1616

@@ -155,7 +155,8 @@ def upgrade() -> None:
155155
sa.Column('id', sa.String(36), nullable=False),
156156
sa.Column('timestamp', sa.DateTime(timezone=True), nullable=False),
157157
sa.Column('correlation_id', sa.String(64), nullable=True),
158-
sa.Column('action', sa.String(50), nullable=False),
158+
sa.Column('request_id', sa.String(64), nullable=True),
159+
sa.Column('action', sa.String(100), nullable=False),
159160
sa.Column('resource_type', sa.String(100), nullable=False),
160161
sa.Column('resource_id', sa.String(255), nullable=False),
161162
sa.Column('resource_name', sa.String(500), nullable=True),
@@ -180,6 +181,7 @@ def upgrade() -> None:
180181
# Create indexes for audit_trails
181182
op.create_index('ix_audit_trails_timestamp', 'audit_trails', ['timestamp'], unique=False)
182183
op.create_index('ix_audit_trails_correlation_id', 'audit_trails', ['correlation_id'], unique=False)
184+
op.create_index('ix_audit_trails_request_id', 'audit_trails', ['request_id'], unique=False)
183185
op.create_index('ix_audit_trails_action', 'audit_trails', ['action'], unique=False)
184186
op.create_index('ix_audit_trails_resource_type', 'audit_trails', ['resource_type'], unique=False)
185187
op.create_index('ix_audit_trails_resource_id', 'audit_trails', ['resource_id'], unique=False)

mcpgateway/routers/log_search.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,10 +225,13 @@ class AuditTrailResponse(BaseModel):
225225
"""Audit trail response model."""
226226
id: str
227227
timestamp: datetime
228+
correlation_id: Optional[str] = None
228229
action: str
229230
resource_type: str
230231
resource_id: Optional[str]
232+
resource_name: Optional[str] = None
231233
user_id: str
234+
user_email: Optional[str] = None
232235
success: bool
233236
requires_review: bool
234237
data_classification: Optional[str]
@@ -629,10 +632,13 @@ async def get_audit_trails(
629632
AuditTrailResponse(
630633
id=str(trail.id),
631634
timestamp=trail.timestamp,
635+
correlation_id=trail.correlation_id,
632636
action=trail.action,
633637
resource_type=trail.resource_type,
634638
resource_id=trail.resource_id,
639+
resource_name=trail.resource_name,
635640
user_id=trail.user_id,
641+
user_email=trail.user_email,
636642
success=trail.success,
637643
requires_review=trail.requires_review,
638644
data_classification=trail.data_classification,

mcpgateway/static/admin.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21603,6 +21603,7 @@ function displayCorrelationTrace(trace) {
2160321603
*/
2160421604
async function showSecurityEvents() {
2160521605
setPerformanceAggregationVisibility(false);
21606+
setLogFiltersVisibility(false);
2160621607
try {
2160721608
const response = await fetch(`${getRootPath()}/api/logs/security-events?limit=50&resolved=false`, {
2160821609
method: 'GET',
@@ -21833,7 +21834,7 @@ function displayAuditTrail(trails) {
2183321834
const resourceName = trail.resource_name || trail.resource_id || '-';
2183421835
const resourceDisplay = `
2183521836
<div class="font-medium">${escapeHtml(resourceName)}</div>
21836-
${trail.resource_id && trail.resource_name ? `<div class="text-xs text-gray-500">ID: ${escapeHtml(trail.resource_id)}</div>` : ''}
21837+
${trail.resource_id && trail.resource_name ? `<div class="text-xs text-gray-500">UUID: ${escapeHtml(trail.resource_id)}</div>` : ''}
2183721838
${trail.data_classification ? `<div class="text-xs text-orange-600 mt-1">🔒 ${escapeHtml(trail.data_classification)}</div>` : ''}
2183821839
`;
2183921840

mcpgateway/templates/admin.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@
370370
class="text-gray-700 dark:text-gray-300 block px-4 py-2 text-sm hover:bg-gray-100 dark:hover:bg-gray-700"
371371
role="menuitem"
372372
onclick="showTab('logs')"
373-
>📋 Structured Logs</a
373+
>📋 System Logs</a
374374
>
375375
<a
376376
href="#version-info"
@@ -579,7 +579,7 @@
579579
<h2
580580
class="text-lg font-medium text-gray-900 dark:text-white mb-4"
581581
>
582-
📋 Structured Logs & Analytics
582+
📋 System Logs
583583
</h2>
584584

585585
<!-- Quick Actions -->
@@ -630,8 +630,8 @@
630630
class="px-1.5 block w-full border-gray-300 rounded-md shadow-sm dark:bg-gray-700 dark:border-gray-600 text-gray-700 dark:text-gray-300"
631631
onchange="handlePerformanceAggregationChange(event)"
632632
>
633-
<option value="5m">Aggregate by 5-minute windows</option>
634-
<option value="24h">Aggregate by 24-hour windows</option>
633+
<option value="5m">5 minutes</option>
634+
<option value="24h">24 hours</option>
635635
</select>
636636
</div>
637637
</div>

0 commit comments

Comments
 (0)