Skip to content

Commit d8e1b9b

Browse files
committed
suppress creation of default metrics
only share metrics from the bus, no "meta" metrics like go_, process_ etc Signed-off-by: ChanderG <[email protected]>
1 parent e88aa25 commit d8e1b9b

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

cmd/mq2prom.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func main() {
2929

3030
sm := manager.NewSimpleManager()
3131

32-
sm.Init(manager.MetricSpec{
32+
registry := sm.Init(manager.MetricSpec{
3333
Metrics: conf.Metrics,
3434
})
3535

@@ -62,7 +62,8 @@ func main() {
6262
}
6363
log.Info("Subscribed to topic: ", conf.MqConfig.Topic)
6464

65-
http.Handle("/metrics", promhttp.Handler())
65+
handler := promhttp.HandlerFor(registry, promhttp.HandlerOpts{})
66+
http.Handle("/metrics", handler)
6667

6768
log.Info("Starting up metric endpoint at :9641")
6869
log.Fatal(http.ListenAndServe(mqIP+":9641", nil))

pkg/metric-manager/manager.go

+7-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
type Manager interface {
1010
// Initialize the Metric Manager with a list of metrics to track
11-
Init(MetricSpec)
11+
Init(MetricSpec) *prometheus.Registry
1212
// Update a set of metrics in a single message payload
1313
Update(MQPayload)
1414
}
@@ -26,7 +26,9 @@ func NewSimpleManager() *SimpleManager {
2626
}
2727
}
2828

29-
func (m *SimpleManager) Init(metricSpec MetricSpec) {
29+
func (m *SimpleManager) Init(metricSpec MetricSpec) *prometheus.Registry {
30+
r := prometheus.NewRegistry()
31+
3032
for _, mc := range metricSpec.Metrics {
3133
var metricCollector prometheus.Collector
3234

@@ -44,12 +46,14 @@ func (m *SimpleManager) Init(metricSpec MetricSpec) {
4446
}
4547

4648
// register this metric with Prometheus
47-
prometheus.MustRegister(metricCollector)
49+
r.MustRegister(metricCollector)
4850

4951
// store this metric collector for future use
5052
m.metrics[mc.MQName] = metricCollector
5153
m.metricTypes[mc.MQName] = mc.Type
5254
}
55+
56+
return r
5357
}
5458

5559
func (m *SimpleManager) Update(mqpayload MQPayload) {

0 commit comments

Comments
 (0)