Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule (input_label_visible) fix issues related to visible text on an input element V4 #2214

Open
wants to merge 5 commits into
base: main-4.x
Choose a base branch
from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 25, 2025

  • Rule bug: input_label_visible

This PR is related to the following issue(s):

Testing reference:

  • test/v2/checker/accessibility/rules/input_label_visible_ruleunit/button_label.html
  • before the fix: a false positive "Needs Review" message "The input element does not have an associated visible label"
  • After the fix, the "Needs Review" should disappear. Note that there are three buttons in the test case, one with visible text (pass), another with a tooltip (pass), and others with no visible text (should still fail).

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • NA Links to design artifacts
  • Links to video walkthrough of user experience
  • Other - Action Artifacts

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review February 25, 2025 17:02
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tested
Results noted in issue #2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixrule (input_label_visible) should not trigger when button input contains visible text
4 participants