Give guides a home button (and more) by removing custom navbar #10942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restores the default "home" button for guides - restores "next" and "previous" links for each page - restores "source" button for each page (.rst or .md)
This was hidden before because a custom navbar took over.
|
Based on feedback from @DieuwertjeBloemen at https://dataverse.zulipchat.com/#narrow/channel/446770-docs/topic/no.20home.20button/near/477816742 I added "About Dataverse" to the navbar in 5c5812e. It links to dataverse.org Here's an updated screenshot:
|
DieuwertjeBloemen
approved these changes
Mar 21, 2025
|
@ofahimIQSS @DieuwertjeBloemen @CharityEverett, and I touched on this during the documentation working group meeting this morning. As I mentioned above, I might want to remove For now Omer and I agreed to keep this going and put it on the board. I also merged the latest from develop in. Please keep the feedback coming! |
navbar_from_dataverse_org.js is no longer used, so we delete it. It operated on navbar.html, which we deleted already. The script was setting the site name to "Dataverse Project" and adding the Dataverse icon next to it. We're now doing this elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: you can preview this pull request at https://dataverse-guide--10942.org.readthedocs.build/en/10942/
What this PR does / why we need it:
The Documentation Working Group has been talking about how there's no "home" button when clicking around the guides.
This pull request takes a somewhat bold approach of removing the custom navbar entirely. The following changes can be observed:
Which issue(s) this PR closes:
Special notes for your reviewer:
This is a draft. At minimum, I think I also want to remove the following unused cruft:
There's probably CSS that can be removed as well, as well as other files or at least lines.
Suggestions on how to test this:
Try the preview link above.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. See before and after below.
Before
After
After ("Site" dropdown)
After ("Page" dropdown)
Is there a release notes update needed for this change?:
Yes, not yet included.
Additional documentation:
None.