✏️ Fix linting and formatting

Author: MathisFederico

.github/workflows/draft-pdf.yml

@@ -14,7 +14,7 @@ jobs:
           journal: joss
           paper-path: paper.md
       - name: Upload
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v4
         with:
           name: paper
           path: paper.pdf

src/hcraft/behaviors/__init__.py

@@ -1 +1 @@
-""" Module to define HEBGraphs for any HierarchyCraft environment. """
+"""Module to define HEBGraphs for any HierarchyCraft environment."""

src/hcraft/behaviors/actions.py

@@ -1,4 +1,4 @@
-""" Module to define Action nodes for the HEBGraph of the HierarchyCraft environment. """
+"""Module to define Action nodes for the HEBGraph of the HierarchyCraft environment."""
 
 from typing import TYPE_CHECKING
 
@@ -13,7 +13,6 @@
 
 
 class DoTransformation(Action):
-
     """Perform a transformation."""
 
     def __init__(self, transformation: "Transformation", env: "HcraftEnv") -> None:

src/hcraft/behaviors/behaviors.py

@@ -1,4 +1,4 @@
-""" Module for handcrafted Behavior with HEBGraph in any HierarchyCraft environment. """
+"""Module for handcrafted Behavior with HEBGraph in any HierarchyCraft environment."""
 
 from typing import TYPE_CHECKING, Dict, List, Optional, Union
 
@@ -22,7 +22,6 @@
 
 
 class GetItem(Behavior):
-
     """Behavior for getting an item"""
 
     def __init__(
@@ -59,7 +58,6 @@ def build_graph(self) -> HEBGraph:
 
 
 class DropItem(Behavior):
-
     """Behavior for dropping an item"""
 
     def __init__(
@@ -96,7 +94,6 @@ def build_graph(self) -> HEBGraph:
 
 
 class PlaceItem(Behavior):
-
     """Behavior for getting an item in any of the given zones.
 
     If no zones are given, places in any of the zones were the item can be placed.
@@ -199,7 +196,6 @@ def _item_is_in_stack(self, stacks: Optional[List["Stack"]]) -> bool:
 
 
 class ReachZone(Behavior):
-
     """Behavior for going into a zone"""
 
     def __init__(
@@ -232,7 +228,6 @@ def build_graph(self) -> HEBGraph:
 
 
 class AbleAndPerformTransformation(Behavior):
-
     """Behavior for abling then performing any transformation."""
 
     def __init__(

src/hcraft/behaviors/feature_conditions.py

@@ -1,4 +1,4 @@
-""" Module to define FeatureCondition nodes for the HEBGraph of the HierarchyCraft environment. """
+"""Module to define FeatureCondition nodes for the HEBGraph of the HierarchyCraft environment."""
 
 from typing import TYPE_CHECKING, Optional
 
@@ -14,7 +14,6 @@
 
 
 class HasStack(FeatureCondition):
-
     """FeatureCondition to check if player has an Item in a given quantity."""
 
     def __init__(self, env: "HcraftEnv", stack: Stack) -> None:
@@ -37,7 +36,6 @@ def __call__(self, observation) -> int:
 
 
 class HasLessStack(FeatureCondition):
-
     """FeatureCondition to check if player has an Item in less than a given quantity."""
 
     def __init__(self, env: "HcraftEnv", stack: Stack) -> None:
@@ -59,7 +57,6 @@ def __call__(self, observation) -> int:
 
 
 class IsInZone(FeatureCondition):
-
     """FeatureCondition to check if player is in a Zone."""
 
     def __init__(self, env: "HcraftEnv", zone: Zone) -> None:
@@ -82,7 +79,6 @@ def __call__(self, observation) -> int:
 
 
 class HasZoneItem(FeatureCondition):
-
     """FeatureCondition to check if a Zone has the given property."""
 
     def __init__(

src/hcraft/behaviors/utils.py

@@ -1,4 +1,4 @@
-""" Module for utility functions to apply on handcrafted Behavior. """
+"""Module for utility functions to apply on handcrafted Behavior."""
 
 from typing import Dict, Set, Union
 

src/hcraft/examples/minecraft/env.py

@@ -1,6 +1,6 @@
 # pylint: disable=arguments-differ, inconsistent-return-statements
 
-""" MineHcraft Environment
+"""MineHcraft Environment
 
 HierarchyCraft environment adapted to the Minecraft inventory
 
@@ -32,7 +32,6 @@
 
 
 class MineHcraftEnv(HcraftEnv):
-
     """MineHcraft Environment: A minecraft-like HierarchyCraft Environment.
 
     Default purpose is None (sandbox).

src/hcraft/examples/minecraft/items.py

@@ -1,10 +1,11 @@
-""" Minecraft Items
+"""Minecraft Items
 
 All used minecraft items.
 They are three kinds of items: Loots and McItems that can be found,
 and other items that can only be obtain through hcraft.
 
 """
+
 from dataclasses import dataclass
 from typing import List, Optional, Union
 

src/hcraft/examples/minecraft/tools.py

@@ -1,4 +1,4 @@
-""" Minecraft Tools
+"""Minecraft Tools
 
 All used minecraft tools
 

src/hcraft/examples/minecraft/transformations.py

@@ -1,4 +1,4 @@
-""" Minecraft Recipes
+"""Minecraft Recipes
 
 All used Minecraft recipies.
 

src/hcraft/examples/minecraft/zones.py

@@ -1,4 +1,4 @@
-""" Minecraft Zones
+"""Minecraft Zones
 
 Abstract zones to simulate simply a Minecraft environment.
 

src/hcraft/examples/random_simple/env.py

@@ -1,6 +1,6 @@
 # pylint: disable=no-member
 
-""" Random HierarchyCraft Environment
+"""Random HierarchyCraft Environment
 
 Generate a random HierarchyCraft environment using basic constructor rules.
 
@@ -18,7 +18,6 @@
 
 
 class RandomHcraftEnv(HcraftEnv):
-
     """Random HierarchyCraft Environment"""
 
     def __init__(

src/hcraft/render/__init__.py

@@ -1 +1 @@
-""" Render : Module for rendering HierarchyCraft environments. """
+"""Render : Module for rendering HierarchyCraft environments."""

src/hcraft/render/render.py

@@ -1,6 +1,6 @@
 # pylint: disable=no-member
 
-""" Rendering of the HierarchyCraft environments """
+"""Rendering of the HierarchyCraft environments"""
 
 import os
 import sys

src/hcraft/render/utils.py

@@ -1,4 +1,4 @@
-""" Utilitaries functions for rendering of the HierarchyCraft environments """
+"""Utilitaries functions for rendering of the HierarchyCraft environments"""
 
 import logging
 import os

src/hcraft/render/widgets.py

@@ -1,4 +1,4 @@
-""" Widgets for rendering of the HierarchyCraft environments """
+"""Widgets for rendering of the HierarchyCraft environments"""
 
 from enum import Enum
 from typing import TYPE_CHECKING, Dict, List, Optional, Union

src/hcraft/solving_behaviors.py

@@ -40,7 +40,6 @@
 
 """
 
-
 from typing import TYPE_CHECKING, Dict
 
 from hebg import Behavior
@@ -55,7 +54,6 @@
 from hcraft.requirements import RequirementNode, req_node_name
 from hcraft.task import GetItemTask, GoToZoneTask, PlaceItemTask, Task
 
-from hebg.unrolling import unroll_graph
 
 if TYPE_CHECKING:
     from hcraft.env import HcraftEnv

src/hcraft/task.py

@@ -147,9 +147,9 @@ def build(self, world: "World"):
         else:
             zones_slots = np.array([world.slot_from_zone(self.zone)])
         zone_item_slot = world.zones_items.index(self.item_stack.item)
-        self._terminate_zones_items[
-            zones_slots, zone_item_slot
-        ] = self.item_stack.quantity
+        self._terminate_zones_items[zones_slots, zone_item_slot] = (
+            self.item_stack.quantity
+        )
 
     def _is_terminal(self, state: "HcraftState") -> bool:
         if self.zone is None:

src/hcraft/transformation.py

@@ -138,7 +138,6 @@
 
 """
 
-
 from typing import TYPE_CHECKING, Dict, List, Optional, Set, Tuple, Union, Any
 from enum import Enum
 from dataclasses import dataclass

tests/custom_checks.py

@@ -7,7 +7,7 @@
 def check_np_equal(array: np.ndarray, expected_array: np.ndarray):
     check.is_true(
         np.all(array == expected_array),
-        msg=f"Got:\n{array}\nExpected:\n{expected_array}\nDiff:{array-expected_array}",
+        msg=f"Got:\n{array}\nExpected:\n{expected_array}\nDiff:{array - expected_array}",
     )
 
 

tests/examples/test_random.py

@@ -1,4 +1,3 @@
-import gymnasium
 import pytest
 import pytest_check as check
 

tests/examples/test_recursive.py

@@ -1,5 +1,4 @@
 import networkx as nx
-import pytest
 import pytest_check as check
 from hcraft.examples.light_recursive import LightRecursiveHcraftEnv
 

tests/planning/test_mineHcraft.py

@@ -1,4 +1,4 @@
-""" Module testing utils functions for hcraft behaviors. """
+"""Module testing utils functions for hcraft behaviors."""
 
 from pathlib import Path
 from typing import TYPE_CHECKING