Skip to content

Commit ad602c6

Browse files
github-actions[bot]CompatHelper Juliamtfishman
authored
CompatHelper: bump compat for MatrixAlgebraKit to 0.3, (keep existing compat) (#172)
Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Matt Fishman <[email protected]> Co-authored-by: mtfishman <[email protected]>
1 parent dc37e20 commit ad602c6

File tree

3 files changed

+24
-14
lines changed

3 files changed

+24
-14
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "BlockSparseArrays"
22
uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4"
33
authors = ["ITensor developers <[email protected]> and contributors"]
4-
version = "0.10.1"
4+
version = "0.10.2"
55

66
[deps]
77
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
@@ -41,7 +41,7 @@ GPUArraysCore = "0.1.0, 0.2"
4141
LinearAlgebra = "1.10"
4242
MacroTools = "0.5.13"
4343
MapBroadcast = "0.1.5"
44-
MatrixAlgebraKit = "0.2.2"
44+
MatrixAlgebraKit = "0.2.2, 0.3"
4545
SparseArraysBase = "0.7.1"
4646
SplitApplyCombine = "1.2.3"
4747
TensorAlgebra = "0.3.2"

test/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ DiagonalArrays = "0.3"
3131
GPUArraysCore = "0.2"
3232
JLArrays = "0.2"
3333
LinearAlgebra = "1"
34-
MatrixAlgebraKit = "0.2.5"
34+
MatrixAlgebraKit = "0.2.5, 0.3"
3535
Random = "1"
3636
SafeTestsets = "0.1"
3737
SparseArraysBase = "0.7"

test/test_abstract_blocktype.jl

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,29 +106,39 @@ arrayts = (Array, JLArray)
106106
a = BlockSparseMatrix{elt,AbstractMatrix{elt}}(undef, [2, 3], [2, 3])
107107
a[Block(1, 1)] = dev(randn(elt, 2, 2))
108108
for f in (left_orth, left_polar, qr_compact, qr_full)
109-
if arrayt === Array
109+
if arrayt Array && f left_orth
110+
@test_broken f(a)
111+
else
110112
u, c = f(a)
111113
@test u * c a
112-
@test isisometry(u; side=:left)
113-
else
114-
@test_broken f(a)
114+
if arrayt Array
115+
@test isisometry(u; side=:left)
116+
else
117+
# TODO: Fix comparison with UniformScaling on GPU.
118+
@test_broken isisometry(u; side=:left)
119+
end
115120
end
116121
end
117122
for f in (right_orth, right_polar, lq_compact, lq_full)
118-
if arrayt === Array
123+
if arrayt Array && f right_orth
124+
@test_broken f(a)
125+
else
119126
c, u = f(a)
120127
@test c * u a
121-
@test isisometry(u; side=:right)
122-
else
123-
@test_broken f(a)
128+
if arrayt Array
129+
@test isisometry(u; side=:right)
130+
else
131+
# TODO: Fix comparison with UniformScaling on GPU.
132+
@test_broken isisometry(u; side=:right)
133+
end
124134
end
125135
end
126136
for f in (svd_compact, svd_full, svd_trunc)
127-
if arrayt === Array
137+
if arrayt Array && (f svd_full || f svd_trunc)
138+
@test_broken f(a)
139+
else
128140
u, s, v = f(a)
129141
@test u * s * v a
130-
else
131-
@test_broken f(a)
132142
end
133143
end
134144
end

0 commit comments

Comments
 (0)