Incident.applyMatchingRules: Simplify Source ID comparison

Author: oxzi

internal/incident/incident.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"slices"
 	"strconv"
 	"sync"
 	"time"
@@ -401,32 +400,27 @@ func (i *Incident) applyMatchingRules(ctx context.Context, tx *sqlx.Tx, ev *even
 		i.Rules = make(map[int64]struct{})
 	}
 
-	sourceRulesInfo, ok := i.runtimeConfig.RulesBySource[ev.SourceId]
-	if !ok {
-		i.logger.Errorw("Event refers to non-existing source", zap.Int64("source_id", ev.SourceId))
-		return fmt.Errorf("cannot lookup event source %d", ev.SourceId)
-	}
-
 	for _, ruleId := range ev.RuleIds {
 		ruleIdInt, err := strconv.ParseInt(ruleId, 10, 64)
 		if err != nil {
 			i.logger.Errorw("Event rule is not an integer", zap.String("rule_id", ruleId), zap.Error(err))
 			return fmt.Errorf("cannot convert rule id %q to an int: %w", ruleId, err)
 		}
 
-		if !slices.Contains(sourceRulesInfo.RuleIDs, ruleIdInt) {
-			i.logger.Errorw("Event rule does not belong to source",
-				zap.Int64("source_id", ev.SourceId),
-				zap.Int64("rule_id", ruleIdInt))
-			return fmt.Errorf("event rule %d does not belong to source %d", ruleIdInt, ev.SourceId)
-		}
-
 		r, ok := i.runtimeConfig.Rules[ruleIdInt]
 		if !ok {
 			i.logger.Errorw("Event refers to non-existing event rule, might got deleted", zap.Int64("rule_id", ruleIdInt))
 			return fmt.Errorf("cannot apply unknown rule %d", ruleIdInt)
 		}
 
+		if r.SourceID != ev.SourceId {
+			i.logger.Errorw("Rule source ID does not match event source ID",
+				zap.Int64("event_source_id", ev.SourceId),
+				zap.Int64("rule_source_id", r.SourceID),
+				zap.Int64("rule_id", ruleIdInt))
+			return fmt.Errorf("rule %d source ID %d does not match event source %d", ruleIdInt, r.SourceID, ev.SourceId)
+		}
+
 		if _, ok := i.Rules[r.ID]; !ok {
 			i.Rules[r.ID] = struct{}{}
 			i.logger.Infow("Rule matches", zap.Object("rule", r))