From 4011d28e679ae581a14c357376ae81f8960cebfa Mon Sep 17 00:00:00 2001
From: "Timothy G. Rundle" <timothy.rundle@volvo.com>
Date: Tue, 30 Oct 2018 20:52:56 -0400
Subject: [PATCH] LizardReportParser Unit Test exposing issue with space in
 folder and/or file names

---
 .../swift/LizardReportParserTest.java         | 98 +++++++++++++++++++
 .../src/test/resources/lizard-report.xml      | 41 ++++++++
 2 files changed, 139 insertions(+)
 create mode 100644 sonar-swift-plugin/src/test/java/com/backelite/sonarqube/swift/LizardReportParserTest.java
 create mode 100644 sonar-swift-plugin/src/test/resources/lizard-report.xml

diff --git a/sonar-swift-plugin/src/test/java/com/backelite/sonarqube/swift/LizardReportParserTest.java b/sonar-swift-plugin/src/test/java/com/backelite/sonarqube/swift/LizardReportParserTest.java
new file mode 100644
index 00000000..5b6e4531
--- /dev/null
+++ b/sonar-swift-plugin/src/test/java/com/backelite/sonarqube/swift/LizardReportParserTest.java
@@ -0,0 +1,98 @@
+/**
+ * backelite-sonar-swift-plugin - Enables analysis of Swift and Objective-C projects into SonarQube.
+ * Copyright © 2015 Backelite (${email})
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package com.backelite.sonarqube.swift;
+
+import com.backelite.sonarqube.swift.complexity.LizardReportParser;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Captor;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.sonar.api.batch.fs.*;
+import org.sonar.api.batch.measure.Metric;
+import org.sonar.api.batch.sensor.SensorContext;
+import org.sonar.api.batch.sensor.measure.NewMeasure;
+
+import java.io.File;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public class LizardReportParserTest {
+
+    @Mock
+    SensorContext sensorContext;
+
+    @Mock
+    FileSystem fileSystem;
+
+    @Mock
+    FilePredicates filePredicates;
+
+    @Mock
+    FilePredicate filePredicate;
+
+    @Mock
+    InputFile inputFile;
+
+    @Mock
+    NewMeasure<Integer> newMeasure;
+
+    @Captor
+    ArgumentCaptor<String> hasRelativePathCaptor;
+
+    @Captor
+    ArgumentCaptor<InputComponent> onCaptor;
+
+    @Captor
+    ArgumentCaptor<Metric<Integer>> forMetricCaptor;
+
+    @Captor
+    ArgumentCaptor<Integer> withValueCaptor;
+
+
+    @Test
+    public void parseSimpleFile() {
+
+        LizardReportParser parser = new LizardReportParser(sensorContext);
+        File xmlFile = new File("src/test/resources/lizard-report.xml");
+
+        when(sensorContext.<Integer>newMeasure()).thenReturn(newMeasure);
+        when(newMeasure.on(onCaptor.capture())).thenReturn(newMeasure);
+        when(newMeasure.forMetric(forMetricCaptor.capture())).thenReturn(newMeasure);
+        when(newMeasure.withValue(withValueCaptor.capture())).thenReturn(newMeasure);
+
+        when(sensorContext.fileSystem()).thenReturn(fileSystem);
+        when(fileSystem.predicates()).thenReturn(filePredicates);
+        when(filePredicates.hasRelativePath(hasRelativePathCaptor.capture())).thenReturn(filePredicate);
+        when(fileSystem.hasFiles(filePredicate)).thenReturn(true);
+        when(fileSystem.inputFile(filePredicate)).thenReturn(inputFile);
+
+        parser.parseReport(xmlFile);
+
+        assertEquals(5, onCaptor.getAllValues().size());
+        assertEquals(5, forMetricCaptor.getAllValues().size());
+
+        assertEquals(Arrays.asList(1, 4, 8, 5, 46), withValueCaptor.getAllValues());
+        assertEquals(Arrays.asList("./Folder With Space/File With Space.swift"), hasRelativePathCaptor.getAllValues());
+    }
+
+}
diff --git a/sonar-swift-plugin/src/test/resources/lizard-report.xml b/sonar-swift-plugin/src/test/resources/lizard-report.xml
new file mode 100644
index 00000000..d8b444de
--- /dev/null
+++ b/sonar-swift-plugin/src/test/resources/lizard-report.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" ?>
+<?xml-stylesheet type="text/xsl" href="https://raw.githubusercontent.com/terryyin/lizard/master/lizard.xsl"?>
+<cppncss>
+	<measure type="Function">
+		<labels>
+			<label>Nr.</label>
+			<label>NCSS</label>
+			<label>CCN</label>
+		</labels>
+		<item name="methodName(...) at ./Folder With Space/File With Space.swift:14">
+			<value>1</value>
+			<value>4</value>
+			<value>1</value>
+		</item>
+		<average label="NCSS" value="8"/>
+		<average label="CCN" value="1"/>
+	</measure>
+	<measure type="File">
+		<labels>
+			<label>Nr.</label>
+			<label>NCSS</label>
+			<label>CCN</label>
+			<label>Functions</label>
+		</labels>
+		<item name="./Folder With Space/File With Space.swift">
+			<value>1</value>
+			<value>46</value>
+			<value>8</value>
+			<value>5</value>
+		</item>
+		<average label="NCSS" value="80"/>
+		<average label="CCN" value="13"/>
+		<average label="Functions" value="5"/>
+		<sum label="NCSS" value="19537"/>
+		<sum label="CCN" value="3194"/>
+		<sum label="Functions" value="1420"/>
+		<average label="NCSS" value="13"/>
+		<average label="CCN" value="2"/>
+	</measure>
+</cppncss>
+