Suggestions

[IgorMundstein]

Do you have any suggestions? Please feel free to talk about them. Approved comments are pinned, and old ones are deleted.

Suggestions

• Publish the app to Microsoft Store (In analysis) (That will require the framework upgrade to 4.6.2; consequently, it won't support Windows XP, Vista, and Server 2003)

[kingsznhone]

I strong suggest add .NET6/8 build. Publish project on multi runtime build. i.e. .NET4/6/8.
Firstly, it solve Microsoft Store publish issue.
.NET 4 build for old version windows compatibility.
Secondly, dotnet6/8 have massive performance enhancement on modern hardware. Startup time is close to CPP native exe.
Even aggressive, add modern UI framework like WPFUI into dotnet6/8 build.
dotnet 6/8 can publish a complex APP into single .exe file.
I'm interested in contributing to the modernization of this project.

[IgorMundstein]

I have directed your PR to a new branch but still have some queries and concerns regarding the proposed changes. I believe these changes would be better implemented in a new application with additional features, such as a disk cleaner and registry cleaner. We could consider releasing a version of the application exclusively on the Microsoft Store. I am unsure, but I want you to use valuable time effectively. Therefore, please only spend a little bit of time on this. I will review the changes on Sunday.

[IgorMundstein]

I have noted an essential part of the project that appears to be missing. I want to avoid using third-party libraries, even though they may be easier. I believe relying on libraries can lead to bugs or obsolescence. We aim to create a simple yet effective application that works well with hardware and memory limitations. To achieve this, we can use the features of the .NET framework and manually implement things such as MVVM, DI, and user controls. We must keep the single executable file without requiring extra files or an installer.

Asynchronous programming may seem faster, but the optimization process is just running in multiple threads without waiting for the end. If you run the optimization twice, you may notice that the memory cleared in the notification will fluctuate, as shown in this image.

While I appreciate the updates you've suggested to the project, there are a few points I would like to address:

1. It's unclear whether the optimization is faster; it just runs without waiting for an ending callback.
2. We can implement the change from a checkbox to a toggle button in the current version.
3. Removing the functionality to expand and collapse the window from the main window has changed its behavior.
4. Changing the notification library can cause issues. For example, notifications may no longer appear in the Windows message center, which can affect showing or editing the tray icon. Using the framework's native features allows Windows to control how notifications are displayed. While it may not be perfect, Microsoft maintains it with each new release of Windows.

[kingsznhone]

Some explaination about your concern.

1. Parallel optimize task pool is definitly faster than single thread execute. but I did not finish the async/await code yet. so It's behavior a little bit strange now.

2. none.

3. Expand and collapse function is missing, yes. I was focus on most important function on new UI. Need more time to reproduce unimportant logics from old version.

4. I don't like the notification library too. It just a temp solution for testing. A win32 native notifications wrapper is what i'm expected.

5. single executable file compile is no problem after .NET6. We can embedded hundreds library file into one exe in publish now.

Additionally. I don't understand your hostility to third-party libraries.
I agree that UI library is optional, unstable in some case.
But Communitytoolkit.MVVM and DI libraries are use widely over world. it's stability was proven by time and practice.
It simplified project structure, reduce mantainance difficulty. Building our own wheels is sometimes a dangerous thing.

What I've done is just a draft and it does have all kinds of bugs. But everything will be better in future.

[IgorMundstein]

Apps maintenance may seem straightforward for those familiar with a particular library, but it can be challenging for those just starting to learn how to use it. If you solely rely on the .NET framework resource, you will have a richer learning curve as you will be able to learn the fundamentals of C# programming. In the past, I have successfully learned to use third-party libraries that are no longer updated today.

This project is relatively small, and an update to the framework has already provided benefits. The use of MVVM and DI in this project is only partially necessary and was introduced out of preference and for educational purposes. It's important to note that using third-party libraries to develop small applications is optional, as they often come with more features than what is being used, which can cause slowdowns. In this case, the project is simple and portable, consisting of a single executable without installers. Many users appreciate it. However, for larger projects, using ready-made libraries would make more sense.

The app needs to remain as one executable and should be able to run on old Windows versions. Although I would like to upgrade the framework, it is not practical to keep multiple executables. Many websites only provide the latest version as a single executable that points to the latest release on GitHub. The ability to publish the app to the Microsoft store is highly beneficial, but it needs to be tested because the executable requires signing, which can cost $300 or more. I've heard that Microsoft provides signing for free if an app is published on the store, but I need to check. Also, Microsoft doesn't like apps with administrative privileges, so this must be tested.

[kingsznhone]

mvvm packege is not adding extra burden into project .It's basically a code generator.
the name space of DI library Microsoft.Extensions.DependencyInjection
It's a platform extension component like math , http,Diagnostics, IO. Maintainence by the most talent engineer in microsoft. It is almost an official library.
Contemporary software development is more like lego than carpentry. Use DI extension is the best practice in WPF & ASP .NET Core. Same for the MVVM library for WPF. It has actually become a compulsory knowlege in .NET dev.
For those who want to learn MVVM & DI implements detail, just to go to package source repo, will get everything he need.
I have same experience of third-party library stop maintainence. It does get a little annoying. But there must be something better to replace it.

Acoording to Steam Hardware & Software Survey
Less than 1% PC is runnning on Windows 7 or earlier over the world today .
Does it really make sense to retain compatibility with grandpa systems in the future?

What about freeze v2.8, keep self-made DI&MVVM inplements in that branch for educational purposes. Write a tip in README "For those grandpa systems, download v2.8 release"

I have experience of publish a software to microsoft store. There is no signature issue, only partner center register needed. It will cost about $100 in my memory.
Administrative privileges is not allowed in 2020, I don't know what about now. We can do some research on it.

[a-s-russo]

Could you please include instructions on how to uninstall Windows Memory Cleaner in the README file? I've downloaded and run it and selected 'Run on startup', so now I cannot delete the downloaded executable file because it is always in use. Related to this is the fact that I can't open the UI now and turn off this setting, because I cannot find the app in the tray.

[IgorMundstein]

There is no installation. You can always find any app running on Task Manager.

Open the Windows task manager, go to details, and look for WinMemoryCleaner.exe. Right-click and End process.

So, you can delete the executable, and it won't start anymore.

[a-s-russo]

Thanks for your prompt reply and explanation. The related issue I had was that the app didn't appear automatically in the system tray after rebooting (and having previously selected 'Run on startup'). Double-clicking on the executable file, or pressing the optimisation shortcut key, after rebooting, wouldn't open the app either, so I was struggling to open it to turn this setting off. Of course, any app can be terminated via Task Manager as you say, but that's not a very elegant solution/ideal user experience. Is this a bug perhaps?

[IgorMundstein]

Version 2.8 was released four months ago, and there have been no reports like yours. It works for me on Windows 11.

There are websites offering this app for download; however, I cannot guarantee that they have not modified it.

Make sure you have the original version. Download: https://github.com/IgorMundstein/WinMemoryCleaner/releases/download/2.8/WinMemoryCleaner.exe

Turn off and on the setting, restart your machine, and check if the error persists. Also, check Windows settings as the app may be hidden by it: https://support.microsoft.com/en-us/windows/customize-the-taskbar-notification-area-e159e8d2-9ac5-b2bd-61c5-bb63c1d437c3

[a-s-russo]

Ok, thanks for explaining further. Will keep this in mind.

[andreofgyn]

Hey, Igor, nice app, can you please add to the windows log what caused it to run?

For instance:

• Low Memory (user configurable);
• Timed (user configurable);
• Manually by the user.

[IgorMundstein]

Sure. I'll include improved log information in the next version. Thank you for your suggestion.