Skip to content

Commit 73c70ee

Browse files
authored
Merge pull request openwallet-foundation#3429 from jamshale/change-tdw-naming
Change did:tdw resolver naming to did:webvh
2 parents 8eba663 + 6e7427f commit 73c70ee

File tree

8 files changed

+55
-51
lines changed

8 files changed

+55
-51
lines changed

acapy_agent/messaging/tests/test_valid.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
CREDENTIAL_TYPE_VALIDATE,
1313
DID_KEY_VALIDATE,
1414
DID_POSTURE_VALIDATE,
15-
DID_TDW_VALIDATE,
15+
DID_WEBVH_VALIDATE,
1616
ENDPOINT_TYPE_VALIDATE,
1717
ENDPOINT_VALIDATE,
1818
INDY_CRED_DEF_ID_VALIDATE,
@@ -115,23 +115,23 @@ def test_indy_did(self):
115115
INDY_DID_VALIDATE("Q4zqM7aXqm7gDQkUVLng9h")
116116
INDY_DID_VALIDATE("did:sov:Q4zqM7aXqm7gDQkUVLng9h")
117117

118-
def test_tdw_did(self):
119-
valid_tdw_dids = [
120-
"did:tdw:QmUchSB5f5DJQks9CeyLJjhAy4iKJcYzRyiuYq3sjV13px:example.com",
121-
"did:tdw:QmZiKXwQVfyZVuvCsuHpQh4arSUpEmeVVRvSfv3uiEycSr:example.com%3A5000",
118+
def test_webvh_did(self):
119+
valid_webvh_dids = [
120+
"did:webvh:QmUchSB5f5DJQks9CeyLJjhAy4iKJcYzRyiuYq3sjV13px:example.com",
121+
"did:webvh:QmZiKXwQVfyZVuvCsuHpQh4arSUpEmeVVRvSfv3uiEycSr:example.com%3A5000",
122122
]
123-
for valid_tdw_did in valid_tdw_dids:
124-
DID_TDW_VALIDATE(valid_tdw_did)
123+
for valid_webvh_did in valid_webvh_dids:
124+
DID_WEBVH_VALIDATE(valid_webvh_did)
125125

126-
non_valid_tdw_dids = [
126+
non_valid_webvh_dids = [
127127
"did:web:QmUchSB5f5DJQks9CeyLJjhAy4iKJcYzRyiuYq3sjV13px",
128128
# Did urls are not allowed
129-
"did:tdw:QmP9VWaTCHcyztDpRj9XSHvZbmYe3m9HZ61KoDtZgWaXVU:example.com%3A5000#z6MkkzY9skorPaoEbCJFKUo7thD8Yb8MBs28aJRopf1TUo9V",
130-
"did:tdw:QmZiKXwQVfyZVuvCsuHpQh4arSUpEmeVVRvSfv3uiEycSr:example.com%3A5000/whois",
129+
"did:webvh:QmP9VWaTCHcyztDpRj9XSHvZbmYe3m9HZ61KoDtZgWaXVU:example.com%3A5000#z6MkkzY9skorPaoEbCJFKUo7thD8Yb8MBs28aJRopf1TUo9V",
130+
"did:webvh:QmZiKXwQVfyZVuvCsuHpQh4arSUpEmeVVRvSfv3uiEycSr:example.com%3A5000/whois",
131131
]
132-
for non_valid_tdw_did in non_valid_tdw_dids:
132+
for non_valid_webvh_did in non_valid_webvh_dids:
133133
with self.assertRaises(ValidationError):
134-
DID_TDW_VALIDATE(non_valid_tdw_did)
134+
DID_WEBVH_VALIDATE(non_valid_webvh_did)
135135

136136
def test_indy_raw_public_key(self):
137137
non_indy_raw_public_keys = [

acapy_agent/messaging/valid.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -319,17 +319,19 @@ def __init__(self):
319319
)
320320

321321

322-
class DIDTdw(Regexp):
323-
"""Validate value against did:tdw specification."""
322+
class DIDWebvh(Regexp):
323+
"""Validate value against did:webvh specification."""
324324

325-
EXAMPLE = "did:tdw:QmP9VWaTCHcyztDpRj9XSHvZbmYe3m9HZ61KoDtZgWaXVU:example.com%3A5000"
326-
PATTERN = re.compile(r"^(did:tdw:)([a-zA-Z0-9%._-]*:)*[a-zA-Z0-9%._-]+$")
325+
EXAMPLE = (
326+
"did:webvh:QmP9VWaTCHcyztDpRj9XSHvZbmYe3m9HZ61KoDtZgWaXVU:example.com%3A5000"
327+
)
328+
PATTERN = re.compile(r"^(did:webvh:)([a-zA-Z0-9%._-]*:)*[a-zA-Z0-9%._-]+$")
327329

328330
def __init__(self):
329331
"""Initialize the instance."""
330332

331333
super().__init__(
332-
DIDTdw.PATTERN, error="Value {input} is not in W3C did:tdw format"
334+
DIDWebvh.PATTERN, error="Value {input} is not in W3C did:webvh format"
333335
)
334336

335337

@@ -1017,8 +1019,8 @@ def __init__(
10171019
DID_WEB_VALIDATE = DIDWeb()
10181020
DID_WEB_EXAMPLE = DIDWeb.EXAMPLE
10191021

1020-
DID_TDW_VALIDATE = DIDTdw()
1021-
DID_TDW_EXAMPLE = DIDTdw.EXAMPLE
1022+
DID_WEBVH_VALIDATE = DIDWebvh()
1023+
DID_WEBVH_EXAMPLE = DIDWebvh.EXAMPLE
10221024

10231025
ROUTING_KEY_VALIDATE = RoutingKey()
10241026
ROUTING_KEY_EXAMPLE = RoutingKey.EXAMPLE

acapy_agent/resolver/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ async def setup(context: InjectionContext):
4949
await web_resolver.setup(context)
5050
registry.register_resolver(web_resolver)
5151

52-
tdw_resolver = ClassProvider(
53-
"acapy_agent.resolver.default.tdw.TdwDIDResolver"
52+
webvh_resolver = ClassProvider(
53+
"acapy_agent.resolver.default.webvh.WebvhDIDResolver"
5454
).provide(context.settings, context.injector)
55-
await tdw_resolver.setup(context)
56-
registry.register_resolver(tdw_resolver)
55+
await webvh_resolver.setup(context)
56+
registry.register_resolver(webvh_resolver)
5757

5858
if context.settings.get("resolver.universal"):
5959
universal_resolver = ClassProvider(
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import pytest
22

33
from ....core.profile import Profile
4-
from ....messaging.valid import DIDTdw
4+
from ....messaging.valid import DIDWebvh
55
from ....utils.testing import create_test_profile
6-
from ..tdw import TdwDIDResolver
6+
from ..webvh import WebvhDIDResolver
77

8-
TEST_DID = "did:tdw:Qma6mc1qZw3NqxwX6SB5GPQYzP4pGN2nXD15Jwi4bcDBKu:domain.example"
8+
TEST_DID = "did:webvh:Qma6mc1qZw3NqxwX6SB5GPQYzP4pGN2nXD15Jwi4bcDBKu:domain.example"
99

1010

1111
@pytest.fixture
1212
def resolver():
1313
"""Resolver fixture."""
14-
yield TdwDIDResolver()
14+
yield WebvhDIDResolver()
1515

1616

1717
@pytest.fixture
@@ -21,16 +21,16 @@ async def profile():
2121

2222

2323
@pytest.mark.asyncio
24-
async def test_supported_did_regex(profile, resolver: TdwDIDResolver):
24+
async def test_supported_did_regex(profile, resolver: WebvhDIDResolver):
2525
"""Test the supported_did_regex."""
26-
assert resolver.supported_did_regex == DIDTdw.PATTERN
26+
assert resolver.supported_did_regex == DIDWebvh.PATTERN
2727
assert await resolver.supports(
2828
profile,
2929
TEST_DID,
3030
)
3131

3232

3333
@pytest.mark.asyncio
34-
async def test_resolve(resolver: TdwDIDResolver, profile: Profile):
34+
async def test_resolve(resolver: WebvhDIDResolver, profile: Profile):
3535
"""Test resolve method."""
3636
assert await resolver.resolve(profile, TEST_DID)
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
1-
"""TDW DID Resolver.
1+
"""WEBVH DID Resolver.
22
3-
Resolution is performed by the did_tdw library.
3+
Resolution is performed by the did_webvh library.
44
"""
55

66
from re import Pattern
77
from typing import Optional, Sequence, Text
88

9-
from did_tdw.resolver import ResolutionResult, resolve_did
9+
from did_webvh.resolver import ResolutionResult, resolve_did
1010

1111
from ...config.injection_context import InjectionContext
1212
from ...core.profile import Profile
13-
from ...messaging.valid import DIDTdw
13+
from ...messaging.valid import DIDWebvh
1414
from ..base import BaseDIDResolver, ResolverType
1515

1616

17-
class TdwDIDResolver(BaseDIDResolver):
18-
"""TDW DID Resolver."""
17+
class WebvhDIDResolver(BaseDIDResolver):
18+
"""WEBVH DID Resolver."""
1919

2020
def __init__(self):
21-
"""Initialize the TDW DID Resolver."""
21+
"""Initialize the WEBVH DID Resolver."""
2222
super().__init__(ResolverType.NATIVE)
2323

2424
async def setup(self, context: InjectionContext):
25-
"""Perform required setup for TDW DID resolution."""
25+
"""Perform required setup for WEBVH DID resolution."""
2626

2727
@property
2828
def supported_did_regex(self) -> Pattern:
29-
"""Return supported DID regex of TDW DID Resolver."""
30-
return DIDTdw.PATTERN
29+
"""Return supported DID regex of WEBVH DID Resolver."""
30+
return DIDWebvh.PATTERN
3131

3232
async def _resolve(
3333
self, profile: Profile, did: str, service_accept: Optional[Sequence[Text]] = None
3434
) -> dict:
35-
"""Resolve DID using TDW."""
35+
"""Resolve DID using WEBVH."""
3636
response: ResolutionResult = await resolve_did(did)
3737
if response.resolution_metadata and response.resolution_metadata.get("error"):
3838
return response.resolution_metadata

acapy_agent/wallet/did_method.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ def holder_defined_did(self) -> HolderDefinedDid:
9090
holder_defined_did=HolderDefinedDid.NO,
9191
)
9292

93-
TDW = DIDMethod(
94-
name="tdw",
93+
WEBVH = DIDMethod(
94+
name="webvh",
9595
key_types=[ED25519, X25519],
9696
rotation=False,
9797
holder_defined_did=HolderDefinedDid.NO,
@@ -109,7 +109,7 @@ def __init__(self) -> None:
109109
WEB.method_name: WEB,
110110
PEER2.method_name: PEER2,
111111
PEER4.method_name: PEER4,
112-
TDW.method_name: TDW,
112+
WEBVH.method_name: WEBVH,
113113
}
114114

115115
def registered(self, method: str) -> bool:

poetry.lock

Lines changed: 8 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ uuid_utils = "^0.10.0"
5050
# did libraries
5151
did-peer-2 = "^0.1.2"
5252
did-peer-4 = "^0.1.4"
53-
did-tdw = "^0.2.1"
53+
did-webvh = "^0.2.1"
5454

5555
# Verifiable Credentials
5656
indy-credx = "~1.1.1"

0 commit comments

Comments
 (0)