Skip to content

Commit d452a48

Browse files
authored
Merge pull request #135 from Infisical/daniel/remove-print-from-cli
fix: removed print from login in silent mode
2 parents 6312b76 + a22af63 commit d452a48

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

packages/cmd/login.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ var loginCmd = &cobra.Command{
7373
presetDomain := config.INFISICAL_URL
7474

7575
clearSelfHostedDomains, err := cmd.Flags().GetBool("clear-domains")
76+
77+
if err != nil {
78+
util.HandleError(err)
79+
}
80+
silentMode, err := cmd.Flags().GetBool("silent")
7681
if err != nil {
7782
util.HandleError(err)
7883
}
@@ -148,7 +153,8 @@ var loginCmd = &cobra.Command{
148153
}
149154

150155
domainFlagExplicitlySet := cmd.Flags().Changed("domain")
151-
usePresetDomain, err := usePresetDomain(presetDomain, domainFlagExplicitlySet)
156+
shouldPrintInfo := !silentMode && !plainOutput
157+
usePresetDomain, err := usePresetDomain(presetDomain, domainFlagExplicitlySet, shouldPrintInfo)
152158

153159
if err != nil {
154160
util.HandleError(err)
@@ -436,7 +442,7 @@ func DomainOverridePrompt() (bool, error) {
436442
return selectedOption == OVERRIDE, err
437443
}
438444

439-
func usePresetDomain(presetDomain string, domainFlagExplicitlySet bool) (bool, error) {
445+
func usePresetDomain(presetDomain string, domainFlagExplicitlySet bool, shouldPrintInfo bool) (bool, error) {
440446
infisicalConfig, err := util.GetConfigFile()
441447
if err != nil {
442448
return false, fmt.Errorf("askForDomain: unable to get config file because [err=%s]", err)
@@ -474,7 +480,9 @@ func usePresetDomain(presetDomain string, domainFlagExplicitlySet bool) (bool, e
474480
whilte := color.New(color.FgGreen)
475481
boldWhite := whilte.Add(color.Bold)
476482
time.Sleep(time.Second * 1)
477-
boldWhite.Printf("[INFO] Using domain '%s' from domain flag or INFISICAL_API_URL environment variable\n", parsedDomain)
483+
if shouldPrintInfo {
484+
boldWhite.Printf("[INFO] Using domain '%s' from domain flag or INFISICAL_API_URL environment variable\n", parsedDomain)
485+
}
478486

479487
return true, nil
480488
}

0 commit comments

Comments
 (0)