Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sending notifications process #85

Open
aabounegm opened this issue Jan 8, 2020 · 3 comments
Open

Improve sending notifications process #85

aabounegm opened this issue Jan 8, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@aabounegm
Copy link
Member

Add proper debounce to the new_arrivals notification https://github.com/illright/innopoints-backend/blob/1303c953823820382066b0202b96d20ae8971910/innopoints/views/product.py#L121

Can easily be solved after solving the issue of sending notifications in a separate thread (using threading.Timer)
Both tasks are in the scope of this issue.

@aabounegm aabounegm added the enhancement New feature or request label Jan 8, 2020
@aabounegm aabounegm added this to the Backlog milestone Jan 8, 2020
@illright
Copy link
Member

Actually, this APScheduler thing seems a little more mature than that, with persistence options (though I'm not sure if we really need to protect against restarts for this type of notification).

@aabounegm
Copy link
Member Author

It feels like an overkill while threading is built-in. The only issue that remained was to understand how Flask threading works to not break things by mistake.

@illright
Copy link
Member

That's the thing, I really don't think we should be messing with Flask's thread management (not to mention workers) when established solutions are readily available

@illright illright removed this from the Backlog milestone Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants