Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to share a directory in My Files #934

Open
slim0 opened this issue Feb 14, 2025 · 9 comments
Open

Allows to share a directory in My Files #934

slim0 opened this issue Feb 14, 2025 · 9 comments
Assignees
Milestone

Comments

@slim0
Copy link
Contributor

slim0 commented Feb 14, 2025

I guess this would probably means to make all objects with a given prefix public.

@fcomte
Copy link
Contributor

fcomte commented Feb 14, 2025

sharing is providing a tempory signed link to data and it's not doable for directory.

user can already set a directory public in Onyxia

I am not sure we want to make that

@slim0
Copy link
Contributor Author

slim0 commented Feb 17, 2025

Sorry, miss-understanding on my side.
Indeed, we can already share a folder by making it public using the "eye icon". And I also can understand you don't want to allow sharing a folder for a given amount of time like you did for files.

But, once a folder has been make public, there is no way of retrieving/copying the public URL of that folder (which is possible for a file using the "Share" button).
It would be great to be able to retrieve that URL. On our side, we think that this can be done using the "Share" button (to be consistent with the files behavior).

@ddecrulle

This comment has been minimized.

@fcomte
Copy link
Contributor

fcomte commented Feb 17, 2025

What will you do with this link ? @slim0
There is nothing at the directory level

@slim0
Copy link
Contributor Author

slim0 commented Feb 17, 2025

Hi @fcomte,
I will take a basic example to describe the need here.
You are maybe aware of the ZARR file format for storing large multidimensional array data. We are using it a lot, and unlike the NetCDF format, it is no longer a file but a folder containing lots of files.

Then, using the xarray library, we can load the dataset in ZARR format like this:

import xarray

zarr_folder = "https://s3.waw3-1.cloudferro.com/mdl-arco-time-008/arco/ARCTIC_ANALYSISFORECAST_PHY_002_001/cmems_mod_arc_phy_anfc_6km_detided_P1D-m_202311/timeChunked.zarr"

xarray.open_zarr(zarr_folder)

Thanks

@fcomte
Copy link
Contributor

fcomte commented Feb 17, 2025

I understand, I am not sure that share is the good wording for that.
We have also a button : copy object name, that help to copy the object name without domain name and bucket name.
We may consider offer copy shortcut with https:// and s3:// including bucket name ?

@slim0
Copy link
Contributor Author

slim0 commented Feb 17, 2025

I don't know either. But I'm just proposing that because it's what has been done for files.

Image

@fcomte
Copy link
Contributor

fcomte commented Feb 17, 2025

Yes, but for directories, the term doesn’t have a direct meaning, as only specific folders are used in certain libraries (e.g., Parquet directory, Zarr directory…).

I'm a bit hesitant to use the same terminology for a significantly different purpose.

Do you need this feature quickly ? @ddecrulle will work on a new design for sharing and copy by including action button directly on each line of the explorer.

@slim0
Copy link
Contributor Author

slim0 commented Feb 17, 2025

We don't "need" this feature "quickly". We just thought it would be better to have it and that it can also be something you want.
We let you manage the roadmap the way you prefer as we know you have a lot to do.

@fcomte fcomte added this to the File explorer milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants