Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules/ThirdParty/NrrdIO missing UpdateFromUpstream.sh script #5260

Open
seanm opened this issue Feb 27, 2025 · 4 comments
Open

Modules/ThirdParty/NrrdIO missing UpdateFromUpstream.sh script #5260

seanm opened this issue Feb 27, 2025 · 4 comments
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@seanm
Copy link
Contributor

seanm commented Feb 27, 2025

Modules/ThirdParty/NrrdIO seems to be one of the only ones with no upstream specified and no UpdateFromUpstream.sh script.

At first I thought the project was inactive, looking at for example: https://sourceforge.net/p/teem/news/

But in fact there are recent commits (2024-11-30): https://sourceforge.net/p/teem/code/HEAD/tree/


Perhaps I'm not finding it, but there seems to be no build option to turn this library off in ITK?

@seanm seanm added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Feb 27, 2025
@dzenanz
Copy link
Member

dzenanz commented Feb 27, 2025

Here is a link to a relevant discussion, and the most relevant post.

@dzenanz
Copy link
Member

dzenanz commented Feb 27, 2025

Also tagging @kindlmann.

@seanm
Copy link
Contributor Author

seanm commented Feb 27, 2025

Here is a link to a relevant discussion, and the most relevant post.

Ah, quite a long discussion and backstory, thanks. I guess though that no one actually did the things discussed.

It's not something I personally use, but I would be interesting in disabling it from an ITK build. I looked, but didn't find any options with 'nrrd' or 'teem' in the name. Is is currently possible to disable this when building ITK?

@dzenanz
Copy link
Member

dzenanz commented Feb 27, 2025

It is one of the default modules. You would need to disable ITK_BUILD_DEFAULT_MODULES and ITKGroup_Core to get the option Module_ITKIONRRD. That is because Module_ITKTestKernel, which is part of Core, depends on ITKIONRRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

No branches or pull requests

2 participants