Skip to content

Move upgradeTxBody to testlib #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Soupstraw opened this issue May 22, 2025 · 0 comments · May be fixed by #5088
Open

Move upgradeTxBody to testlib #5072

Soupstraw opened this issue May 22, 2025 · 0 comments · May be fixed by #5088
Assignees
@teodanciu
Labels
💳 technical-debt Issues related to technical debt we introduced 🕵️ testing

Comments

@Soupstraw
Copy link
Contributor

The upgradeTxBody method in EraTx is only used for testing and should not be used in production, since the actual translation of transactions between eras happens via reserialization. Because of that it makes sense to move upgradeTxBody to the testlib, perhaps making it a method of EraTest.
@Soupstraw Soupstraw added 🕵️ testing 💳 technical-debt Issues related to technical debt we introduced labels May 22, 2025
@teodanciu teodanciu self-assigned this May 27, 2025
@teodanciu teodanciu linked a pull request May 28, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodanciu teodanciu

Labels
💳 technical-debt Issues related to technical debt we introduced 🕵️ testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move upgrade functions for tx, body, auxData and wits to testlib IntersectMBO/cardano-ledger
2 participants
@teodanciu @Soupstraw