From b032a2c1ba2357341a45adfb2e9aef40dd8e5602 Mon Sep 17 00:00:00 2001 From: Seungheon Oh Date: Sat, 15 Nov 2025 01:45:23 -0600 Subject: [PATCH 1/2] Use correct "golden.eval" postfix for workflow and script --- .github/workflows/compare-golden-budgets.yaml | 2 +- scripts/eval-percent-diff.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/compare-golden-budgets.yaml b/.github/workflows/compare-golden-budgets.yaml index c178d49b8ca..573b2767e62 100644 --- a/.github/workflows/compare-golden-budgets.yaml +++ b/.github/workflows/compare-golden-budgets.yaml @@ -3,7 +3,7 @@ name: "🏆 Compare Golden Budgets" on: pull_request: paths: - - '**.eval.golden' + - '**.golden.eval' jobs: run-script: diff --git a/scripts/eval-percent-diff.sh b/scripts/eval-percent-diff.sh index f9e528ef045..01786f1de95 100755 --- a/scripts/eval-percent-diff.sh +++ b/scripts/eval-percent-diff.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash -# diff‑budget.sh – show percent deltas for *.eval.golden metrics +# diff‑budget.sh – show percent deltas for *.golden.eval metrics # Usage: diff‑budget.sh [-t] [] # -t output as Markdown tables instead of colored text @@ -31,9 +31,9 @@ if [[ $# -gt 1 ]]; then usage elif [[ $# -eq 1 ]]; then BASE="$1" - GIT_DIFF_CMD=(git diff "$BASE" -- '*.eval.golden') + GIT_DIFF_CMD=(git diff "$BASE" -- '*.golden.eval') else - GIT_DIFF_CMD=(git diff -- '*.eval.golden') + GIT_DIFF_CMD=(git diff -- '*.golden.eval') fi # --- run diff and post‑process ---------------------------------------------- From b036a14240c605b1ee1da2d4fff67227c6a51ba6 Mon Sep 17 00:00:00 2001 From: Seungheon Oh Date: Mon, 17 Nov 2025 16:44:31 -0600 Subject: [PATCH 2/2] Fix fetching names --- scripts/eval-percent-diff.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/eval-percent-diff.sh b/scripts/eval-percent-diff.sh index 01786f1de95..c804047d45e 100755 --- a/scripts/eval-percent-diff.sh +++ b/scripts/eval-percent-diff.sh @@ -51,7 +51,7 @@ if [[ $TFLAG -eq 1 ]]; then file=""; seen=0; } # new file header: reset seen flag, store filename - /^--- a\/.*\.eval\.golden/ { + /^--- a\/.*\.golden\.eval/ { file = substr($2,3) seen = 0 next @@ -99,7 +99,7 @@ else file=""; seen=0; } # new file header: reset seen flag, store filename - /^--- a\/.*\.eval\.golden/ { + /^--- a\/.*\.golden\.eval/ { file = substr($2,3) seen = 0 next