Skip to content

Commit 51d567c

Browse files
committed
fix: prevent TransactionTooLargeException by removing large list saves from Bundle
1 parent 38ad3bd commit 51d567c

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

app/src/main/java/fr/free/nrw/commons/description/DescriptionEditActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ class DescriptionEditActivity :
100100

101101
if (savedInstanceState != null) {
102102
descriptionAndCaptions = savedInstanceState.getParcelableArrayList(LIST_OF_DESCRIPTION_AND_CAPTION)
103+
?: bundle?.getParcelableArrayList(LIST_OF_DESCRIPTION_AND_CAPTION)
103104
wikiText = savedInstanceState.getString(WIKITEXT)
104105
savedLanguageValue = savedInstanceState.getString(Prefs.DESCRIPTION_LANGUAGE)!!
105106
media = savedInstanceState.getParcelable("media")
@@ -312,7 +313,6 @@ class DescriptionEditActivity :
312313
override fun onSaveInstanceState(outState: Bundle) {
313314
super.onSaveInstanceState(outState)
314315

315-
outState.putParcelableArrayList(LIST_OF_DESCRIPTION_AND_CAPTION, uploadMediaDetailAdapter.items as ArrayList<out Parcelable?>)
316316
outState.putString(WIKITEXT, wikiText)
317317
outState.putString(Prefs.DESCRIPTION_LANGUAGE, savedLanguageValue)
318318
// save Media

app/src/main/java/fr/free/nrw/commons/upload/mediaDetails/UploadMediaDetailFragment.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -898,10 +898,6 @@ class UploadMediaDetailFragment : UploadBaseFragment(), UploadMediaDetailsContra
898898
if (uploadableFile != null) {
899899
outState.putParcelable(UPLOADABLE_FILE, uploadableFile)
900900
}
901-
outState.putParcelableArrayList(
902-
UPLOAD_MEDIA_DETAILS,
903-
ArrayList(uploadMediaDetailAdapter.items)
904-
)
905901
}
906902

907903
override fun onDestroy() {

0 commit comments

Comments
 (0)