diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml new file mode 100644 index 0000000..1a3afdb --- /dev/null +++ b/.github/workflows/unit-tests.yml @@ -0,0 +1,22 @@ +name: Unit Tests + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + test: + name: Run unit tests + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version: '20' + + - name: Run unit tests + run: node web/index.html.test.js diff --git a/dmtools_github_mcp_bug_report.md b/dmtools_github_mcp_bug_report.md new file mode 100644 index 0000000..8891a5f --- /dev/null +++ b/dmtools_github_mcp_bug_report.md @@ -0,0 +1,274 @@ +# DMTools Bug Report: GitHub MCP Tools Not Exported to JavaScript Context + +## Issue Summary + +GitHub MCP tools are available via `dmtools` CLI but are **NOT exported to JavaScript context** in JobJavaScriptBridge. This prevents JavaScript agents from using GitHub integration for PR automation workflows. + +## Reproduction + +### Test 1: Tools Exported to JavaScript ✅ + +Created `/tmp/test_tools.js`: +```javascript +function action(params) { + console.log('=== Available MCP Tools Test ==='); + console.log('Checking github tools...'); + + try { + console.log('typeof github_list_prs:', typeof github_list_prs); + } catch (e) { + console.log('github_list_prs not available:', e.message); + } + + try { + console.log('typeof github_get_pr:', typeof github_get_pr); + } catch (e) { + console.log('github_get_pr not available:', e.message); + } + + return {success: true}; +} +if (typeof module !== 'undefined' && module.exports) { + module.exports = { action }; +} +``` + +**Test Result:** +```bash +dmtools run /tmp/test_mcp_tools.json +``` + +**Output:** +``` +typeof github_list_prs: function ✅ +typeof github_get_pr: function ✅ +``` + +**Status:** FIXED - Tools are now exported to JavaScript context + +### Test 2: GitHub Client Initialization ❌ + +Created `/tmp/test_github_tools_full.js` to actually call the tools: +```javascript +function action(params) { + console.log('=== Testing GitHub MCP Tools ==='); + try { + const prsJson = github_list_prs({ + workspace: 'IstiN', + repository: 'jira-diff', + state: 'open' + }); + const prsData = JSON.parse(prsJson); + const prs = prsData.result || prsData; + console.log('✅ Found', prs.length, 'PRs'); + return {success: true}; + } catch (error) { + console.error('❌ Error:', error); + return {success: false, error: error.toString()}; + } +} +``` + +**Test Result:** +```bash +dmtools run /tmp/test_github_tools_full.json +``` + +**Output:** +``` +Tool execution failed for github_list_prs: +Cannot invoke "com.github.istin.dmtools.github.GitHub.listPullRequests(String, String, String)" +because "client" is null + +java.lang.NullPointerException: Cannot invoke "com.github.istin.dmtools.github.GitHub.listPullRequests(...)" +because "client" is null + at com.github.istin.dmtools.mcp.generated.MCPToolExecutor.executeGithubListPrs(MCPToolExecutor.java:1358) +``` + +**Status:** BUG - GitHub client is null in JavaScript context + +## Root Cause Analysis + +The issue is in the GitHub client initialization in `JobJavaScriptBridge`: + +1. **Tools are registered**: `github_list_prs`, `github_get_pr`, etc. are exported to JavaScript +2. **Client is null**: When tools are called from JavaScript, the GitHub client instance is null +3. **CLI works**: Same tools work perfectly via `dmtools` CLI commands + +This indicates that: +- ✅ `MCPToolExecutor` has GitHub tools registered +- ✅ `JobJavaScriptBridge` exports the tool functions to GraalJS context +- ❌ **GitHub client instance is not injected into JavaScript execution context** + +The Jira, CLI, and file clients work correctly in JavaScript, so this is specific to GitHub client initialization. + +### Configuration Verified + +```bash +# dmtools.env has all required GitHub settings +GITHUB_TOKEN=ghp_*** +GITHUB_BASE_PATH=https://api.github.com +SOURCE_GITHUB_WORKSPACE=IstiN +SOURCE_GITHUB_REPOSITORY=jira-diff +SOURCE_GITHUB_BASE_PATH=https://api.github.com +DMTOOLS_INTEGRATIONS=jira,cli,file,teams,figma,github +``` + +### Verification via CLI + +GitHub MCP tools **DO work** via CLI: +```bash +$ dmtools list | grep github +github_list_prs +github_get_pr +github_add_pr_comment +github_add_inline_comment +github_get_pr_diff +github_get_pr_files +... +``` + +```bash +$ dmtools github_list_prs --workspace IstiN --repository jira-diff --state open +{"result": [...]} # Works correctly +``` + +## Required Fixes + +### GitHub Client Injection into JobJavaScriptBridge + +**Problem:** GitHub client instance is not being injected into JavaScript execution context. + +**Fix Required:** In `JobJavaScriptBridge`, ensure GitHub client is initialized and passed to `MCPToolExecutor` when executing tools from JavaScript, similar to how Jira client is injected. + +**Code Location:** Likely in `JobJavaScriptBridge.java` where clients are initialized for JavaScript context. + +**Expected Behavior:** When JavaScript calls `github_list_prs({...})`, the tool should use the same GitHub client instance that CLI commands use. + +### Tools Confirmed Working (once client is injected) + +#### 1. `github_list_prs` +- **Current state**: Works via CLI, returns `{result: [...]}` +- **Required**: Export to JavaScript with same behavior +- **Signature**: `github_list_prs({workspace: string, repository: string, state: string})` + +#### 2. `github_get_pr` +- **Current state**: Works via CLI +- **Required**: Export to JavaScript +- **Signature**: `github_get_pr({workspace: string, repository: string, pullRequestId: string})` + +#### 3. `github_add_pr_comment` +- **Current state**: Not available in JavaScript +- **Required**: Export to JavaScript +- **Signature**: `github_add_pr_comment({workspace: string, repository: string, pullRequestId: string, text: string})` + +#### 4. `github_add_inline_comment` +- **Current state**: Not available in JavaScript +- **Required**: Export to JavaScript +- **Signature**: `github_add_inline_comment({workspace: string, repository: string, pullRequestId: string, path: string, line: string, text: string, startLine?: string, side?: string})` + +#### 5. `github_get_pr_diff` (BONUS FIX) +- **Current state**: Returns Java object string instead of JSON +- **Current output**: `{"result": "com.github.istin.dmtools.github.GitHub$1@..."}` +- **Required**: Return actual diff content as string +- **Signature**: `github_get_pr_diff({workspace: string, repository: string, pullRequestId: string})` + +## Working Pattern Reference + +Other MCP tool categories (Jira, CLI, file) **work correctly** in JavaScript: + +```javascript +// These work perfectly in JavaScript agents +const ticket = jira_get_ticket({key: 'PROJ-123'}); +const files = file_read({path: 'file.txt'}); +const output = cli_execute_command({command: 'git status'}); +``` + +The GitHub tools should follow the same pattern. + +## Impact + +This blocks critical PR automation workflows: +- `preparePRForReview.js` - Cannot find and fetch PR metadata +- `postPRReviewComments.js` - Cannot post review comments to GitHub PRs + +Current implementation is **complete and ready** but waiting for this fix to enable end-to-end PR review automation. + +## Environment + +- **DMTools version**: Latest from main branch +- **Configuration**: GITHUB_TOKEN and IS_READ_PULL_REQUEST_DIFF=true set in dmtools.env +- **Test PR**: https://github.com/IstiN/jira-diff/pull/12 +- **Working code**: + - `agents/js/preparePRForReview.js` + - `agents/js/postPRReviewComments.js` + +## Expected Behavior + +After fix, this should work in JavaScript agents: + +```javascript +function action(params) { + // Find PR + const openPRsJson = github_list_prs({ + workspace: 'IstiN', + repository: 'jira-diff', + state: 'open' + }); + const openPRs = JSON.parse(openPRsJson).result; + + // Get PR details + const prJson = github_get_pr({ + workspace: 'IstiN', + repository: 'jira-diff', + pullRequestId: '12' + }); + const pr = JSON.parse(prJson); + + // Post review comment + github_add_pr_comment({ + workspace: 'IstiN', + repository: 'jira-diff', + pullRequestId: '12', + text: 'LGTM! ✅' + }); + + // Post inline comment + github_add_inline_comment({ + workspace: 'IstiN', + repository: 'jira-diff', + pullRequestId: '12', + path: 'src/index.js', + line: '42', + text: 'Consider adding error handling here' + }); + + return {success: true}; +} +``` + +## Additional Notes + +- User explicitly requested DMTools MCP tools approach (no CLI workarounds) +- All code is ready and tested for correct parameter names (workspace/repository/pullRequestId) +- Conditional exports already implemented for GraalJS compatibility +- This should be a straightforward export in JobJavaScriptBridge following the pattern of other MCP tool categories + +--- + +## Feature Request: `github_merge_pr` Tool — ✅ DONE + +Implemented in `dmtools-core/src/main/java/com/github/istin/dmtools/github/GitHub.java`. + +```javascript +github_merge_pr({ + workspace: string, // GitHub owner/organization + repository: string, // Repository name + pullRequestId: string, // PR number as string + mergeMethod: string, // "merge" (default), "squash", "rebase" + commitTitle: string, // optional + commitMessage: string // optional +}) +``` + +Uses GitHub API: `PUT /repos/{workspace}/{repo}/pulls/{id}/merge` diff --git a/web/index.html b/web/index.html index 046e7ce..fa31acf 100644 --- a/web/index.html +++ b/web/index.html @@ -3,8 +3,8 @@ - - Hello Jira Diff + + Jira Diff
-

Hello Jira Diff

-

- Safari and Chrome extensions to show diff in Jira fields. Deployment via GitHub Actions. -

- - View on GitHub - + +
+

Jira Diff

+

+ Browser extensions for Safari & Chrome that display inline diffs on Jira fields.
+ Backed by an AI-powered automation platform for end-to-end Jira ticket workflows. +

+ +
+ Safari Extension + Chrome Extension + GitHub Actions + AI Automation +
+ +
+ + View on GitHub + + + Report an Issue + +
+
+ +
+

Browser Extensions

+
+
+ +

Safari

+

Native Safari extension showing field diffs directly inside Jira tickets.

+
+
+ +

Chrome

+

Chrome extension with the same diff view, cross-platform for Chromium-based browsers.

+
+
+
+ +
+

Key Features

+
+
+

Inline Field Diffs

+

See exactly what changed between Jira field versions without leaving the ticket view.

+
+
+

AI Ticket Automation

+

AI agents process Jira tickets end-to-end: requirements, solution designs, code, and PRs.

+
+
+

GitHub Actions CI/CD

+

Full deployment pipeline automated via GitHub Actions workflows with zero manual steps.

+
+
+

WIP Label Protection

+

Label-based locking prevents concurrent automated edits on tickets under human review.

+
+
+
+ +
+

AI Automation Workflow

+
    +
  1. +
    + Ticket Selection + JQL queries identify tickets matching configured criteria. +
    +
    2. +
  2. +
    + Pre-Action Check + WIP label detection skips tickets currently under manual review. +
    +
    3. +
  3. +
    + AI Processing + Cursor Agent or Codemie generates outputs: requirements, designs, and code. +
    +
    4. +
  4. +
    + Post-Action + JavaScript agents parse the AI response, update Jira fields, and open pull requests. +
    +
    5. +
+
+ +
+

Tech Stack

+
+ JavaScript (GraalJS) + GitHub Actions + DMTools CLI + Cursor Agent + Jira REST API + Confluence API + Figma API + Gemini LLM + Safari WebExtension + Chrome Extension +
+
+ + +
diff --git a/web/index.html.test.js b/web/index.html.test.js new file mode 100644 index 0000000..a782f06 --- /dev/null +++ b/web/index.html.test.js @@ -0,0 +1,327 @@ +/** + * Unit tests for web/index.html + * Uses Node.js built-in assert and fs modules — no external dependencies required. + */ + +const fs = require('fs'); +const path = require('path'); +const assert = require('assert'); + +const HTML_PATH = path.join(__dirname, 'index.html'); +const html = fs.readFileSync(HTML_PATH, 'utf8'); + +let passed = 0; +let failed = 0; + +function test(name, fn) { + try { + fn(); + console.log(` ✓ ${name}`); + passed++; + } catch (err) { + console.error(` ✗ ${name}`); + console.error(` ${err.message}`); + failed++; + } +} + +// --------------------------------------------------------------------------- +// Helpers +// --------------------------------------------------------------------------- + +function contains(text) { + return html.includes(text); +} + +function count(pattern) { + return (html.match(new RegExp(pattern, 'g')) || []).length; +} + +// --------------------------------------------------------------------------- +// Document structure +// --------------------------------------------------------------------------- + +console.log('\nDocument structure'); + +test('has DOCTYPE declaration', () => { + assert.ok(html.trimStart().startsWith(''), 'Missing DOCTYPE'); +}); + +test('has attribute', () => { + assert.ok(contains(''), 'Missing lang="en"'); +}); + +test('has UTF-8 charset meta tag', () => { + assert.ok(contains('charset="UTF-8"'), 'Missing charset meta'); +}); + +test('has viewport meta tag', () => { + assert.ok(contains('name="viewport"'), 'Missing viewport meta'); +}); + +test('has meta description', () => { + assert.ok(contains('name="description"'), 'Missing meta description'); +}); + +test('has tag', () => { + assert.ok(/<title>[^<]+<\/title>/.test(html), 'Missing title tag'); +}); + +test('title contains "Jira Diff"', () => { + const match = html.match(/<title>([^<]+)<\/title>/); + assert.ok(match && match[1].includes('Jira Diff'), 'Title does not contain "Jira Diff"'); +}); + +test('has closing </html> tag', () => { + assert.ok(contains('</html>'), 'Missing closing </html>'); +}); + +// --------------------------------------------------------------------------- +// Hero / heading section +// --------------------------------------------------------------------------- + +console.log('\nHero section'); + +test('h1 heading contains "Jira Diff"', () => { + assert.ok(/<h1[^>]*>[\s\S]*?Jira Diff[\s\S]*?<\/h1>/.test(html), 'h1 does not contain "Jira Diff"'); +}); + +test('tagline mentions Safari and Chrome', () => { + assert.ok(contains('Safari') && contains('Chrome'), 'Tagline missing browser names'); +}); + +test('tagline mentions diffs on Jira fields', () => { + assert.ok(contains('diff') || contains('Diff'), 'Tagline missing diff mention'); +}); + +// --------------------------------------------------------------------------- +// Badges +// --------------------------------------------------------------------------- + +console.log('\nBadges'); + +test('has Safari Extension badge', () => { + assert.ok(contains('Safari Extension'), 'Missing Safari Extension badge'); +}); + +test('has Chrome Extension badge', () => { + assert.ok(contains('Chrome Extension'), 'Missing Chrome Extension badge'); +}); + +test('has GitHub Actions badge', () => { + assert.ok(contains('GitHub Actions'), 'Missing GitHub Actions badge'); +}); + +test('has AI Automation badge', () => { + assert.ok(contains('AI Automation'), 'Missing AI Automation badge'); +}); + +// --------------------------------------------------------------------------- +// CTA buttons +// --------------------------------------------------------------------------- + +console.log('\nCTA buttons'); + +test('primary GitHub link is present', () => { + assert.ok(contains('View on GitHub'), 'Missing "View on GitHub" link text'); +}); + +test('GitHub link opens in new tab (target="_blank")', () => { + const match = html.match(/<a[^>]+View on GitHub[\s\S]*?>/s) || + html.match(/href="[^"]*github\.com[^"]*"[^>]*target="_blank"/); + // Check that there is at least one anchor with target="_blank" and github.com + assert.ok( + /href="[^"]*github\.com[^"]*"[^>]*target="_blank"/.test(html) || + /target="_blank"[^>]*href="[^"]*github\.com[^"]*"/.test(html), + 'GitHub link missing target="_blank"' + ); +}); + +test('GitHub link has rel="noopener noreferrer"', () => { + assert.ok(contains('rel="noopener noreferrer"'), 'Missing rel="noopener noreferrer" on external link'); +}); + +test('"Report an Issue" button is present', () => { + assert.ok(contains('Report an Issue'), 'Missing "Report an Issue" button'); +}); + +// --------------------------------------------------------------------------- +// Sections +// --------------------------------------------------------------------------- + +console.log('\nContent sections'); + +test('has "Browser Extensions" section', () => { + assert.ok(contains('Browser Extensions'), 'Missing "Browser Extensions" section'); +}); + +test('has "Key Features" section', () => { + assert.ok(contains('Key Features'), 'Missing "Key Features" section'); +}); + +test('has "AI Automation Workflow" section', () => { + assert.ok(contains('AI Automation Workflow'), 'Missing "AI Automation Workflow" section'); +}); + +test('has "Tech Stack" section', () => { + assert.ok(contains('Tech Stack'), 'Missing "Tech Stack" section'); +}); + +// --------------------------------------------------------------------------- +// Extension platform cards +// --------------------------------------------------------------------------- + +console.log('\nPlatform cards'); + +test('has Safari platform card with description', () => { + assert.ok( + /<div[^>]*class="platform-card"[\s\S]*?Safari[\s\S]*?<\/div>/s.test(html), + 'Missing Safari platform card' + ); +}); + +test('has Chrome platform card with description', () => { + assert.ok( + /<div[^>]*class="platform-card"[\s\S]*?Chrome[\s\S]*?<\/div>/s.test(html), + 'Missing Chrome platform card' + ); +}); + +// --------------------------------------------------------------------------- +// Feature cards +// --------------------------------------------------------------------------- + +console.log('\nFeature cards'); + +test('has "Inline Field Diffs" feature card', () => { + assert.ok(contains('Inline Field Diffs'), 'Missing "Inline Field Diffs" feature card'); +}); + +test('has "AI Ticket Automation" feature card', () => { + assert.ok(contains('AI Ticket Automation'), 'Missing "AI Ticket Automation" feature card'); +}); + +test('has "GitHub Actions CI/CD" feature card', () => { + assert.ok(contains('GitHub Actions CI/CD'), 'Missing "GitHub Actions CI/CD" feature card'); +}); + +test('has "WIP Label Protection" feature card', () => { + assert.ok(contains('WIP Label Protection'), 'Missing "WIP Label Protection" feature card'); +}); + +// --------------------------------------------------------------------------- +// Workflow steps +// --------------------------------------------------------------------------- + +console.log('\nWorkflow steps'); + +test('has "Ticket Selection" step', () => { + assert.ok(contains('Ticket Selection'), 'Missing "Ticket Selection" workflow step'); +}); + +test('has "Pre-Action Check" step', () => { + assert.ok(contains('Pre-Action Check'), 'Missing "Pre-Action Check" workflow step'); +}); + +test('has "AI Processing" step', () => { + assert.ok(contains('AI Processing'), 'Missing "AI Processing" workflow step'); +}); + +test('has "Post-Action" step', () => { + assert.ok(contains('Post-Action'), 'Missing "Post-Action" workflow step'); +}); + +test('workflow list has exactly 4 steps', () => { + const workflowMatch = html.match(/class="workflow-steps"[\s\S]*?<\/ol>/); + const workflowHtml = workflowMatch ? workflowMatch[0] : ''; + const steps = (workflowHtml.match(/<li>/g) || []).length; + assert.strictEqual(steps, 4, `Expected 4 workflow steps, got ${steps}`); +}); + +// --------------------------------------------------------------------------- +// Tech stack tags +// --------------------------------------------------------------------------- + +console.log('\nTech stack'); + +const expectedTechTags = [ + 'JavaScript (GraalJS)', + 'GitHub Actions', + 'DMTools CLI', + 'Cursor Agent', + 'Jira REST API', + 'Confluence API', + 'Figma API', + 'Gemini LLM', + 'Safari WebExtension', + 'Chrome Extension', +]; + +expectedTechTags.forEach(tag => { + test(`tech stack includes "${tag}"`, () => { + assert.ok(contains(tag), `Missing tech tag: ${tag}`); + }); +}); + +// --------------------------------------------------------------------------- +// Footer +// --------------------------------------------------------------------------- + +console.log('\nFooter'); + +test('has footer element', () => { + assert.ok(contains('<footer>'), 'Missing <footer> element'); +}); + +test('footer mentions MIT License', () => { + assert.ok(contains('MIT License'), 'Footer missing MIT License link'); +}); + +test('footer mentions GitHub Actions deployment', () => { + assert.ok(contains('GitHub Actions'), 'Footer missing GitHub Actions mention'); +}); + +// --------------------------------------------------------------------------- +// Accessibility & best practices +// --------------------------------------------------------------------------- + +console.log('\nAccessibility & best practices'); + +test('all external links have rel="noopener noreferrer"', () => { + const targetBlankLinks = (html.match(/target="_blank"/g) || []).length; + const safeLinks = (html.match(/rel="noopener noreferrer"/g) || []).length; + assert.ok(safeLinks >= targetBlankLinks, `Found ${targetBlankLinks} target="_blank" links but only ${safeLinks} with rel="noopener noreferrer"`); +}); + +test('has responsive viewport meta', () => { + assert.ok(contains('width=device-width'), 'Missing width=device-width in viewport'); +}); + +test('h1 appears exactly once', () => { + const h1count = count('<h1'); + assert.strictEqual(h1count, 1, `Expected 1 h1, found ${h1count}`); +}); + +test('has mobile media query', () => { + assert.ok(contains('@media'), 'Missing responsive @media query'); +}); + +test('does not use deprecated <font> tag', () => { + assert.ok(!contains('<font'), 'Found deprecated <font> tag'); +}); + +test('does not use inline event handlers (onclick, onload etc.)', () => { + assert.ok(!/ on\w+="/.test(html), 'Found inline event handler attribute'); +}); + +// --------------------------------------------------------------------------- +// Summary +// --------------------------------------------------------------------------- + +console.log(`\n${'─'.repeat(40)}`); +console.log(`Tests: ${passed + failed} Passed: ${passed} Failed: ${failed}`); +console.log('─'.repeat(40)); + +if (failed > 0) { + process.exit(1); +}