Address comments

Author: sachinjoseph

apps/rush-lib/src/api/RushConfiguration.ts

@@ -265,7 +265,7 @@ export abstract class PackageManagerOptionsConfigurationBase implements IPackage
 export class NpmOptionsConfiguration extends PackageManagerOptionsConfigurationBase {
   /** @internal */
   public constructor(json: INpmOptionsJson) {
-    super(json.environmentVariables);
+    super(json);
   }
 }
 
@@ -327,7 +327,7 @@ export class PnpmOptionsConfiguration extends PackageManagerOptionsConfiguration
 
   /** @internal */
   public constructor(json: IPnpmOptionsJson, commonTempFolder: string) {
-    super(json.environmentVariables);
+    super(json);
     this.pnpmStore = json.pnpmStore || 'local';
     if (EnvironmentConfiguration.pnpmStorePathOverride) {
       this.pnpmStorePath = EnvironmentConfiguration.pnpmStorePathOverride;
@@ -362,7 +362,7 @@ export class YarnOptionsConfiguration extends PackageManagerOptionsConfiguration
 
   /** @internal */
   public constructor(json: IYarnOptionsJson) {
-    super(json.environmentVariables);
+    super(json);
     this.ignoreEngines = !!json.ignoreEngines;
   }
 }

common/reviews/api/rush-lib.api.md

@@ -268,9 +268,9 @@ export abstract class PackageManager {
 export type PackageManagerName = 'pnpm' | 'npm' | 'yarn';
 
 // @public
-export class PackageManagerOptionsConfigurationBase implements IPackageManagerOptionsJsonBase {
+export abstract class PackageManagerOptionsConfigurationBase implements IPackageManagerOptionsJsonBase {
     // @internal
-    protected constructor(environmentVariables?: IConfigurationEnvironment);
+    protected constructor(json: IPackageManagerOptionsJsonBase);
     readonly environmentVariables?: IConfigurationEnvironment;
 }