Address comments

Author: sachinjoseph

apps/rush-lib/src/cli/actions/BaseInstallAction.ts

@@ -64,8 +64,8 @@ export abstract class BaseInstallAction extends BaseRushAction {
     this._maxInstallAttempts = this.defineIntegerParameter({
       parameterLongName: '--max-install-attempts',
       argumentName: 'NUMBER',
-      description: `Overrides the default maximum number of install attempts.`
-        + ` The default value is ${RushConstants.defaultMaxInstallAttempts}.`
+      description: `Overrides the default maximum number of install attempts.`,
+      defaultValue: RushConstants.defaultMaxInstallAttempts
     });
     this._variant = this.defineStringParameter(Variants.VARIANT_PARAMETER);
   }
@@ -104,7 +104,9 @@ export abstract class BaseInstallAction extends BaseRushAction {
       }
     }
 
-    if (this._maxInstallAttempts.value && this._maxInstallAttempts.value < 1) {
+    // Because the 'defautltValue' option on the _maxInstallAttempts parameter is set,
+    // it is safe to assume that the value is not null
+    if (this._maxInstallAttempts.value! < 1) {
       throw new Error(`The value of "${this._maxInstallAttempts.longName}" must be positive.`);
     }
 

apps/rush-lib/src/cli/actions/InstallAction.ts

@@ -4,7 +4,6 @@
 import { BaseInstallAction } from './BaseInstallAction';
 import { IInstallManagerOptions } from '../../logic/InstallManager';
 import { RushCommandLineParser } from '../RushCommandLineParser';
-import { RushConstants } from '../../logic/RushConstants';
 
 export class InstallAction extends BaseInstallAction {
   public constructor(parser: RushCommandLineParser) {
@@ -36,9 +35,9 @@ export class InstallAction extends BaseInstallAction {
       networkConcurrency: this._networkConcurrencyParameter.value,
       collectLogFile: this._debugPackageManagerParameter.value!,
       variant: this._variant.value,
-      maxInstallAttempts: this._maxInstallAttempts.value !== undefined
-        ? this._maxInstallAttempts.value
-        : RushConstants.defaultMaxInstallAttempts
+      // Because the 'defautltValue' option on the _maxInstallAttempts parameter is set,
+      // it is safe to assume that the value is not null
+      maxInstallAttempts: this._maxInstallAttempts.value!
     };
   }
 }

apps/rush-lib/src/cli/actions/UpdateAction.ts

@@ -6,7 +6,6 @@ import { CommandLineFlagParameter } from '@microsoft/ts-command-line';
 import { BaseInstallAction } from './BaseInstallAction';
 import { IInstallManagerOptions } from '../../logic/InstallManager';
 import { RushCommandLineParser } from '../RushCommandLineParser';
-import { RushConstants } from '../../logic/RushConstants';
 
 export class UpdateAction extends BaseInstallAction {
   private _fullParameter: CommandLineFlagParameter;
@@ -64,9 +63,9 @@ export class UpdateAction extends BaseInstallAction {
       networkConcurrency: this._networkConcurrencyParameter.value,
       collectLogFile: this._debugPackageManagerParameter.value!,
       variant: this._variant.value,
-      maxInstallAttempts: this._maxInstallAttempts.value !== undefined
-        ? this._maxInstallAttempts.value
-        : RushConstants.defaultMaxInstallAttempts
+      // Because the 'defautltValue' option on the _maxInstallAttempts parameter is set,
+      // it is safe to assume that the value is not null
+      maxInstallAttempts: this._maxInstallAttempts.value!
     };
   }
 }

apps/rush-lib/src/logic/InstallManager.ts

@@ -1086,7 +1086,7 @@ export class InstallManager {
           if (environmentVariables[envVar].override &&
             environmentVariables[envVar].override === true) {
             setEnvironmentVariable = true;
-            console.log(colors.yellow(`WARNING: Overriding the environment variable with the value set in rush.json.`));
+            console.log(`Overriding the environment variable with the value set in rush.json.`);
           }
           else {
             console.log(colors.yellow(`WARNING: Not overriding the value of the environment variable.`));