Merge branch 'development' into benchmark-total

Author: raffaelladevita

.containers/coatjava.Dockerfile

@@ -23,4 +23,4 @@ ARG REF_NAME=development
 RUN java --version && cd /opt && \
     git clone https://code.jlab.org/hallb/alert/coatjava.git && cd coatjava && \
     git fetch origin && git checkout ${REF_NAME} && ./build-coatjava.sh --quiet && \
-    ./install-clara /opt/clara
+    ./bin/install-clara /opt/clara

.github/workflows/ci.yml

@@ -88,7 +88,7 @@ jobs:
       - name: build
         run: |
           ./build-coatjava.sh --lfs --no-progress -T${{ env.nthreads }}
-          ./install-clara -b -c ./coatjava ./clara
+          ./bin/install-clara -b -c ./coatjava ./clara
       - name: tar # tarball to preserve permissions
         run: |
           tar czvf coatjava.tar.gz coatjava

install-clara bin/install-clarainstall-clara renamed to bin/install-clara

@@ -368,6 +368,6 @@ done
 echo "installed coatjava to: $prefix_dir"
 
 # install clara
-if $installClara; then ./install-clara -c $prefix_dir $clara_home; fi
+if $installClara; then ./bin/install-clara -c $prefix_dir $clara_home; fi
 
 echo "COATJAVA SUCCESSFULLY BUILT !"

build-coatjava.sh

@@ -134,5 +134,9 @@ public static void main(String args[]) {
         for (String name : badEntries.keySet()) {
             System.out.println(name + " " + badEntries.get(name));
         }
+
+        if (nbadevent + nbadrow + nbadentry > 0) {
+            System.exit(7);
+        }
     }
 }

common-tools/clas-io/src/main/java/org/jlab/utils/HipoDiff.java

@@ -179,6 +179,7 @@ else if(this.containsOptions(arguments,"-v","-version")==true){
             }
         }
         if (this.requiresInputList && this.parsedInputList.isEmpty()) {
+            printUsage();
             System.err.println(" \n*** ERROR *** Empty Input List.");
             System.exit(101);
         }

common-tools/clas-utils/src/main/java/org/jlab/utils/options/OptionParser.java

@@ -118,7 +118,7 @@ then
         # install clara
         if ! [ -d clara_installation ]
         then
-            ../../install-clara clara_installation
+            ../../bin/install-clara clara_installation
         fi
     fi