Skip to content

Commit bcb7e2f

Browse files
authored
build: use more appropriate slf4j version for dependency convergence conflict resolution (#1486)
1 parent 5c928dc commit bcb7e2f

1 file changed

Lines changed: 19 additions & 8 deletions

File tree

‎pom.xml‎

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,6 @@
9898
<classifier>linux</classifier>
9999
</dependency>
100100

101-
<dependency>
102-
<groupId>org.slf4j</groupId>
103-
<artifactId>slf4j-api</artifactId>
104-
<version>2.0.19</version>
105-
</dependency>
106-
107101
<dependency>
108102
<groupId>org.apache.commons</groupId>
109103
<artifactId>commons-math3</artifactId>
@@ -185,8 +179,12 @@
185179

186180
<dependency>
187181
<groupId>j4ml</groupId>
188-
<artifactId>j4ml-neuroph</artifactId> <!-- WARNING: if changed, check the `org.apache.commons:commons-lang3` version; see `docs/dependency_conflicts.md` -->
189-
<version>0.9-SNAPSHOT</version>
182+
<artifactId>j4ml-neuroph</artifactId>
183+
<version>0.9-SNAPSHOT</version> <!-- WARNING: if changed:
184+
- check the `org.slf4j:slf4j-api` version
185+
- check the `org.apache.commons:commons-lang3` version
186+
- see `docs/dependency_conflicts.md` for more info
187+
-->
190188
</dependency>
191189

192190
<dependency>
@@ -275,6 +273,19 @@
275273
<version>3.20.0</version> <!-- WARNING: if changed, see `docs/dependency_conflicts.md` -->
276274
</dependency>
277275

276+
<!--
277+
resolve convergence conflict of `org.slf4j:slf4j-api` inherent in dependencies consumed by
278+
`j4ml:j4ml-neuroph:jar:0.9-SNAPSHOT` by choosing the latest version:
279+
- com.github.neuroph:neuroph-core:2.98 uses version 1.7.5
280+
- com.github.neuroph:neuroph-core:2.98 also consumes ch.qos.logback:logback-classic:1.1.2, which uses version 1.7.6
281+
- see `docs/dependency_conflicts.md` for more info
282+
-->
283+
<dependency>
284+
<groupId>org.slf4j</groupId>
285+
<artifactId>slf4j-api</artifactId>
286+
<version>1.7.6</version> <!-- WARNING: if changed, see `docs/dependency_conflicts.md` -->
287+
</dependency>
288+
278289
</dependencies>
279290
</dependencyManagement>
280291

0 commit comments

Comments
 (0)