Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Stability for other StaticVectors while evaluating PolynomialSystem. #46

Open
manuelbb-upb opened this issue Jun 24, 2021 · 0 comments

Comments

@manuelbb-upb
Copy link

Hi,
thanks for the great package!

I noticed, that evaluating a PolynomialSystem at a SVector returns an SVector, but the same does not hold true for SizedVector or MVector.

I currently define

for V in [:SizedVector, :MVector ]
    @eval Base.@propagate_inbounds StaticPolynomials.evaluate( F :: PolynomialSystem, x :: $V ) = $V( StaticPolynomials._evaluate( F, x ) )
    @eval Base.@propagate_inbounds StaticPolynomials.evaluate( F :: PolynomialSystem, x :: $V , p) = $V( StaticPolynomials._evaluate( F, x , p) )
end

in my package, but I think, it would be great to have these definitions in polynomial_system.jl

I guess the other subtypes (FieldVector and SUnitRange) can be neglected.

Should I open a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant