invperm: check if arg is a permutation

Author: gustafsson

src/StaticArrays.jl

@@ -6,7 +6,7 @@ import Base: getindex, setindex!, size, similar, vec, show, length, convert, pro
              promote_rule, map, map!, reduce, mapreduce, foldl, mapfoldl, broadcast,
              broadcast!, conj, hcat, vcat, ones, zeros, one, reshape, fill, fill!, inv,
              iszero, sum, prod, count, any, all, minimum, maximum, extrema,
-             copy, read, read!, write, reverse
+             copy, read, read!, write, reverse, invperm
 
 using Random
 import Random: rand, randn, randexp, rand!, randn!, randexp!

src/util.jl

@@ -74,10 +74,12 @@ TrivialView(a::AbstractArray{T,N}) where {T,N} = TrivialView{typeof(a),T,N}(a)
 @inline drop_sdims(a::StaticArrayLike) = TrivialView(a)
 @inline drop_sdims(a) = a
 
-Base.@propagate_inbounds function invperm(p::StaticVector)
-    # in difference to base, this does not check if p is a permutation (every value unique)
-     ip = similar(p)
-     ip[p] = 1:length(p)
-     similar_type(p)(ip)
+@inline function invperm(p::StaticVector{N,T}) where {N,T<:Integer}
+    ip = zeros(MVector{N,T})
+    @inbounds for i in SOneTo(N)
+        j = p[i]
+        1 <= j <= N && iszero(ip[j]) || throw(ArgumentError("argument is not a permutation"))
+        ip[j] = i
+    end
+    SVector(ip)
 end
-

test/qr.jl

@@ -13,7 +13,7 @@ broadenrandn(::Type{Complex{T}}) where T = Complex{T}(broadenrandn(T), broadenra
 broadenrandn(::Type{T}) where T = randn(T)
 
 Random.seed!(42)
-false && @testset "QR decomposition" begin
+@testset "QR decomposition" begin
     function test_qr(arr)
 
         T = eltype(arr)