Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the broken doctests, and add a CI job that runs the doctests #81

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Fix the broken doctests, and add a CI job that runs the doctests #81

merged 4 commits into from
Nov 1, 2021

Conversation

DilumAluthge
Copy link
Contributor

@DilumAluthge DilumAluthge commented Nov 1, 2021 •
edited
Loading

Fixes #79
Fixes #80

This pull request makes the following changes:

  1. For consistency, use the same .ci/test_and_change_uuid.jl pattern that all of the other external stdlibs use
  2. Add the docs/Project.toml file, and gitignore the docs/Manifest.toml file
  3. Add a CI job that runs the doctests
  4. Fix the broken doctests

@DilumAluthge
Copy link
Contributor Author

This is now ready to review. cc: @staticfloat

@DilumAluthge DilumAluthge mentioned this pull request Nov 1, 2021
Closed
@staticfloat staticfloat merged commit d30dbf6 into JuliaCrypto:master Nov 1, 2021
@DilumAluthge DilumAluthge deleted the dpa/fix-doctests branch November 1, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doctests are failing Run doctests on CI?
2 participants
@DilumAluthge @staticfloat