Skip to content

Remove the stale WeakRefStringArray export and references - #107

Merged
quinnj merged 2 commits into
mainfrom
claude/stale-weakrefstringarray-refs
Oct 27, 2026
Merged

quinnj merged 2 commits into
mainfrom
claude/stale-weakrefstringarray-refs

Conversation

@quinnj

@quinnj quinnj commented Oct 15, 2026

Copy link
Copy Markdown
Member

WeakRefStringArray was removed in b057061, but the module still exports the name, so using WeakRefStrings brings in a binding that throws UndefVarError. The README also still points readers at it.

  • Drop WeakRefStringArray from the export list and add a test that every exported name is defined.
  • README: replace the WeakRefStringArray references with StringArray, and state the actual CI matrix (Julia 1.3, latest and nightly on Linux; latest on 32-bit Windows).
  • StringArray docstring: show the example output current Julia prints.

Verification: the new test fails on main and passes here; full suite passes on Julia 1.3.1 and 1.12.6. The docstring examples were run on 1.12.6 to get their output.

🤖 Generated with Claude Code

WeakRefStringArray was deleted in b057061, but the module still exported
the name and the README still pointed readers at it. Also update the
README test matrix and the StringArray docstring's example output.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (ebedc46) to head (3887bf8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files           1        1           
  Lines         300      300           
=======================================
  Hits          251      251           
  Misses         49       49           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj
quinnj merged commit 34cc2a6 into main Oct 27, 2026
6 checks passed
@quinnj
quinnj deleted the claude/stale-weakrefstringarray-refs branch October 27, 2026 05:17
@quinnj quinnj mentioned this pull request Oct 27, 2026
quinnj referenced this pull request Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant