Repository navigation
Allow InlineStrings 2 - #108
Merged
Merged
Conversation
WeakRefStrings only re-exports the InlineStrings types, and InlineStrings 2 still exports every re-exported name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 83.66% 83.66%
=======================================
Files 1 1
Lines 300 300
=======================================
Hits 251 251
Misses 49 49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
quinnj
referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeakRefStrings re-exports the InlineStrings types but caps InlineStrings at 1.x, so any environment that loads WeakRefStrings 2.0 is held on InlineStrings 1 even though CSV.jl and DataFrames.jl already allow 2. InlineStrings 2 changed the inline strings' memory layout, but it still exports every name re-exported here, and WeakRefStrings uses nothing else from it.
Verification: full suite passes on Julia 1.12.6 with InlineStrings 2.0.1;
String7,InlineStringTypeandInlineStringresolve throughusing WeakRefStrings. On Julia 1.3 to 1.9 the resolver keeps InlineStrings 1.x, since 2.x requires Julia 1.10.A 2.0.1 release would make this available.
🤖 Generated with Claude Code