remove unnecessary push/pop testset calls since record records into the testset anyway

Author: KristofferC

test/runtests.jl

@@ -330,14 +330,11 @@ println("Testing finished in $elapsed")
 
 # construct a testset to render the test results
 o_ts = Test.DefaultTestSet("Overall")
-Test.push_testset(o_ts)
 completed_tests = Set{String}()
 for (testname, (resp,)) in results
     push!(completed_tests, testname)
     if isa(resp, Test.DefaultTestSet)
-        Test.push_testset(resp)
         Test.record(o_ts, resp)
-        Test.pop_testset()
     elseif isa(resp, Tuple{Int,Int})
         fake = Test.DefaultTestSet(testname)
         for i in 1:resp[1]
@@ -346,9 +343,7 @@ for (testname, (resp,)) in results
         for i in 1:resp[2]
             Test.record(fake, Test.Broken(:test, nothing))
         end
-        Test.push_testset(fake)
         Test.record(o_ts, fake)
-        Test.pop_testset()
     elseif isa(resp, RemoteException) && isa(resp.captured.ex, Test.TestSetException)
         println("Worker $(resp.pid) failed running test $(testname):")
         Base.showerror(stdout, resp.captured)
@@ -363,9 +358,7 @@ for (testname, (resp,)) in results
         for t in resp.captured.ex.errors_and_fails
             Test.record(fake, t)
         end
-        Test.push_testset(fake)
         Test.record(o_ts, fake)
-        Test.pop_testset()
     else
         if !isa(resp, Exception)
             resp = ErrorException(string("Unknown result type : ", typeof(resp)))
@@ -376,19 +369,17 @@ for (testname, (resp,)) in results
         # deserialization errors or something similar.  Record this testset as Errored.
         fake = Test.DefaultTestSet(testname)
         Test.record(fake, Test.Error(:nontest_error, testname, nothing, Any[(resp, [])], LineNumberNode(1)))
-        Test.push_testset(fake)
         Test.record(o_ts, fake)
-        Test.pop_testset()
     end
 end
 for test in tests
     (test in completed_tests) && continue
     fake = Test.DefaultTestSet(test)
     Test.record(fake, Test.Error(:test_interrupted, test, nothing,
-                                 [("skipped", [])], LineNumberNode(1)))
-    Test.push_testset(fake)
+            [("skipped", [])], LineNumberNode(1)
+        )
+    )
     Test.record(o_ts, fake)
-    Test.pop_testset()
 end
 println()
 Test.print_test_results(o_ts, 1)