Support resolving small_typeof tags#97
Merged
Merged
Conversation
topolarity
changed the title
small_typeof type tagssmall_typeof tags
topolarity
force-pushed
the
ct/small_typeof
branch
2 times, most recently
from
fc177e3 to
5a139ca
Compare
This avoids a segmentation fault when exploring these special type tags, which are not valid pointers on their own.
topolarity
force-pushed
the
ct/small_typeof
branch
from
5a139ca to
d858a13
Compare
JeffBezanson
reviewed
Nov 4, 2025
| function resolve_static_jl_value(val::LLVM.Value) | ||
| addr = resolve_static_uint(val) | ||
| addr === nothing && return nothing | ||
| return Base.unsafe_pointer_to_objref(Ptr{Cvoid}(addr)) |
Member
There was a problem hiding this comment.
Ideally this would return a Some.
Member
Author
There was a problem hiding this comment.
Good point
Currently only used to resolve types, so it should be benign - but you're right that we should fix this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #96.
This avoids a segmentation fault when exploring these special type tags, which are not valid pointers on their own.